Skip to content

Comments

ci: fix broken workflow#44045

Merged
thaJeztah merged 1 commit intomoby:masterfrom
crazy-max:fix-ci-workflow
Aug 26, 2022
Merged

ci: fix broken workflow#44045
thaJeztah merged 1 commit intomoby:masterfrom
crazy-max:fix-ci-workflow

Conversation

@crazy-max
Copy link
Member

@crazy-max crazy-max commented Aug 26, 2022

ci workflow is malformed (yaml syntax error) and is not triggered anymore since https://github.com/moby/moby/actions/runs/2929193959

image

looks to be the comment added in #44028: 6217f80

to avoid this in the future, I think we should require some checks in this workflow.

cc @thaJeztah

Signed-off-by: CrazyMax [email protected]

Signed-off-by: CrazyMax <[email protected]>
@thaJeztah
Copy link
Member

Ah, dang! 🙈 Well, that was skipping slightly more tests than I wanted to skip 😂

Interesting though; why doesn't GitHub complain it's not correctly formatted (other than "just skip it" )?

@thaJeztah
Copy link
Member

thaJeztah commented Aug 26, 2022

Also trying to somewhat see where the exact error is; I'd expect the working-directory: moby to be flagged as "invalid" if the comment would break the array. My IDE doesn't appear to be catching the problem either, and it actually looks to understand the schema now as well (gives tooltips about fields);

Screenshot 2022-08-26 at 08 16 33

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

Let's bring this in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants