vendor: github.com/moby/buildkit v0.10.4 by thaJeztah · Pull Request #44028 · moby/moby

thaJeztah · 2022-08-24T14:54:04Z

release notes: https://github.com/moby/buildkit/releases/tag/v0.10.4

full diff: moby/buildkit@8e2d9b9...v0.10.4

- A picture of a cute animal (not mandatory but encouraged)

thaJeztah · 2022-08-24T16:29:25Z

Lol updating BuildKit, and getting failiures on the classic builder. I think it's just flakiness with that server; we could consider pushing a pre-built image, but pulling Windows images is also slow, so not sure if that would make things better.

---> ba80c7979f32
Step 9/13 : ADD https://frippery.org/files/busybox/busybox-w32-${BUSYBOX_VERSION}.exe /bin/busybox.exe
ADD failed: Get "https://frippery.org/files/busybox/busybox-w32-FRP-3329-gcf0fa4d13.exe": dial tcp 93.93.131.127:443: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.

let me kick it again

thaJeztah · 2022-08-24T16:33:39Z

Oh! Other failure in BuildKit integration tests; coudl be a flake, but let me post, just in case

=== CONT  TestIntegration/TestNamedImageContextTimestamps/worker=dockerd/frontend=client
dockerfile_test.go:5551:
Error Trace:	dockerfile_test.go:5551
run.go:88
run.go:202
Error:      	Received unexpected error:
exporter "image" could not be found
github.com/moby/buildkit/util/stack.Enable
/src/util/stack/stack.go:77
github.com/moby/buildkit/util/grpcerrors.FromGRPC
/src/util/grpcerrors/grpcerrors.go:188
github.com/moby/buildkit/util/grpcerrors.UnaryClientInterceptor
/src/util/grpcerrors/intercept.go:41
google.golang.org/grpc.(*ClientConn).Invoke
/src/vendor/google.golang.org/grpc/call.go:35
github.com/moby/buildkit/api/services/control.(*controlClient).Solve
/src/api/services/control/control.pb.go:1443
github.com/moby/buildkit/client.(*Client).solve.func2
/src/client/solve.go:208
golang.org/x/sync/errgroup.(*Group).Go.func1
/src/vendor/golang.org/x/sync/errgroup/errgroup.go:57
runtime.goexit
/usr/local/go/src/runtime/asm_amd64.s:1581
failed to solve
github.com/moby/buildkit/client.(*Client).solve.func2
/src/client/solve.go:221
golang.org/x/sync/errgroup.(*Group).Go.func1
/src/vendor/golang.org/x/sync/errgroup/errgroup.go:57
runtime.goexit
/usr/local/go/src/runtime/asm_amd64.s:1581
Test:       	TestIntegration/TestNamedImageContextTimestamps/worker=dockerd/frontend=client
sandbox.go:235: stdout: /usr/bin/dockerd
sandbox.go:235: stderr: /usr/bin/dockerd
sandbox.go:238: > startCmd 2022-08-24 15:09:10.758741918 +0000 UTC m=+81.159107005 [/usr/bin/dockerd --data-root /tmp/integration1341243162/dybz2rofa7t2j/root --exec-root

thaJeztah · 2022-08-24T18:12:20Z

hmm.. GitHub actions went AWOL? don't merge!

thaJeztah · 2022-08-24T22:54:05Z

@tonistiigi @jedevc looks like CI continues failing on one of the BuildKit tests; could one of you have a look if it's genuine, or some flaky test?

thaJeztah · 2022-08-25T19:22:03Z

Discussing with @tonistiigi - looks like there may be a test that's either broken (not compatible with current docker engine), or an actual issue; if it's the test, we need to disable it in buildkit (and override the version of the buildkit integration tests we run)

thaJeztah · 2022-08-25T19:23:02Z

Something similar as the override that was removed in e05f614

Signed-off-by: Sebastiaan van Stijn <[email protected]>

release notes: https://github.com/moby/buildkit/releases/tag/v0.10.4 full diff: moby/buildkit@8e2d9b9...v0.10.4 Signed-off-by: Sebastiaan van Stijn <[email protected]>

thaJeztah · 2022-08-25T19:34:56Z

.github/workflows/ci.yml

-          echo "BUILDKIT_REF=$(./hack/buildkit-ref)" >> $GITHUB_ENV
+# FIXME(thaJeztah) temporarily overriding version to use for tests; see https://github.com/moby/moby/pull/44028#issuecomment-1225964929
+#          echo "BUILDKIT_REF=$(./hack/buildkit-ref)" >> $GITHUB_ENV
+          echo "BUILDKIT_REF=8e2d9b9006caadb74c1745608889a37ba139acc1" >> $GITHUB_ENV


Added this temporary override

thaJeztah · 2022-08-25T22:12:26Z

I'll bring this one in; will create a ticket or PR in BuildKit to skip that test on dockerd

crazy-max · 2022-08-25T23:00:59Z

I'll bring this one in; will create a ticket or PR in BuildKit to skip that test on dockerd

Might bring this commit moby/buildkit@5d4e938

thaJeztah · 2022-08-25T23:25:08Z

@crazy-max that's on your fork? GitHub doesn't show a PR attached to it; yes, we should probably cherry-pick that one into the v0.10 branch

crazy-max · 2022-08-25T23:26:05Z

@thaJeztah This one moby/buildkit#3003

thaJeztah · 2022-08-25T23:29:50Z

Ah, right; looks like that was stalling on the other bits in that PR; perhaps makes sense to open it as a separate one

thaJeztah added area/builder Build status/2-code-review process/cherry-pick area/builder/buildkit Build labels Aug 24, 2022

thaJeztah added this to the v-next milestone Aug 24, 2022

thaJeztah mentioned this pull request Aug 24, 2022

[22.06 backport] vendor: github.com/moby/buildkit v0.10.4 #44029

Merged

thaJeztah added process/cherry-picked and removed process/cherry-pick labels Aug 24, 2022

AkihiroSuda approved these changes Aug 24, 2022

View reviewed changes

thaJeztah closed this Aug 24, 2022

thaJeztah reopened this Aug 24, 2022

thaJeztah added 2 commits August 25, 2022 21:32

gha: temporarily pin BuildKit integration test version

6217f80

Signed-off-by: Sebastiaan van Stijn <[email protected]>

vendor: github.com/moby/buildkit v0.10.4

c500d88

release notes: https://github.com/moby/buildkit/releases/tag/v0.10.4 full diff: moby/buildkit@8e2d9b9...v0.10.4 Signed-off-by: Sebastiaan van Stijn <[email protected]>

thaJeztah force-pushed the bump_buildkit branch from cec4e4d to c500d88 Compare August 25, 2022 19:33

thaJeztah commented Aug 25, 2022

View reviewed changes

thaJeztah merged commit 1808c67 into moby:master Aug 25, 2022

thaJeztah deleted the bump_buildkit branch August 25, 2022 22:12

This was referenced Aug 26, 2022

ci: fix broken workflow #44045

Merged

ci: gha test workflow for integration and unit test #44034

Merged

thaJeztah mentioned this pull request Jul 14, 2025

Windows: Buildkit test failure TestLLBMountPerformance #50389

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

vendor: github.com/moby/buildkit v0.10.4#44028

vendor: github.com/moby/buildkit v0.10.4#44028
thaJeztah merged 2 commits intomoby:masterfrom
thaJeztah:bump_buildkit

thaJeztah commented Aug 24, 2022

Uh oh!

thaJeztah commented Aug 24, 2022

Uh oh!

thaJeztah commented Aug 24, 2022

Uh oh!

thaJeztah commented Aug 24, 2022

Uh oh!

thaJeztah commented Aug 24, 2022

Uh oh!

thaJeztah commented Aug 25, 2022

Uh oh!

thaJeztah commented Aug 25, 2022

Uh oh!

thaJeztah Aug 25, 2022

Uh oh!

thaJeztah commented Aug 25, 2022

Uh oh!

crazy-max commented Aug 25, 2022

Uh oh!

thaJeztah commented Aug 25, 2022

Uh oh!

crazy-max commented Aug 25, 2022

Uh oh!

thaJeztah commented Aug 25, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

thaJeztah commented Aug 24, 2022

Uh oh!

thaJeztah commented Aug 24, 2022

Uh oh!

thaJeztah commented Aug 24, 2022

Uh oh!

thaJeztah commented Aug 24, 2022

Uh oh!

thaJeztah commented Aug 24, 2022

Uh oh!

thaJeztah commented Aug 25, 2022

Uh oh!

thaJeztah commented Aug 25, 2022

Uh oh!

thaJeztah Aug 25, 2022

Choose a reason for hiding this comment

Uh oh!

thaJeztah commented Aug 25, 2022

Uh oh!

crazy-max commented Aug 25, 2022

Uh oh!

thaJeztah commented Aug 25, 2022

Uh oh!

crazy-max commented Aug 25, 2022

Uh oh!

thaJeztah commented Aug 25, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants