Skip to content

Dockerfile: use TARGETPLATFORM with scopeo for frozen images stage#44005

Closed
thaJeztah wants to merge 1 commit intomoby:masterfrom
thaJeztah:frozen_skopeo
Closed

Dockerfile: use TARGETPLATFORM with scopeo for frozen images stage#44005
thaJeztah wants to merge 1 commit intomoby:masterfrom
thaJeztah:frozen_skopeo

Conversation

@thaJeztah
Copy link
Member

frozen-images stage doesn't use the download-frozen-image-v2.sh
anymore so we can effectively use TARGETPLATFORM from global scope.
The test util has been updated accordingly.

In a follow-up we can remove download-frozen-image-v2.sh script but
needs to look first at Dockerfile.e2e which seems not used anymore
in our pipeline.

- A picture of a cute animal (not mandatory but encouraged)

frozen-images stage doesn't use the download-frozen-image-v2.sh
anymore so we can effectively use TARGETPLATFORM from global scope.
The test util has been updated accordingly.

In a follow-up we can remove download-frozen-image-v2.sh script but
needs to look first at Dockerfile.e2e which seems not used anymore
in our pipeline.

Signed-off-by: CrazyMax <[email protected]>
@thaJeztah
Copy link
Member Author

Interesting; doesn't look related, but not sure I've seen this particular error before (integration-test (windows-2022, containerd, ./...));

=== Failed
=== FAIL: github.com/docker/docker/integration/container TestWaitNonBlocked/wait-nonblocking-exit-random (1.64s)
    wait_test.go:44: assertion failed: error is not nil: Error response from daemon: failed to create shim task: hcs::CreateComputeSystem 5d19c8e979a045bb8db34788add4046c27e44e698d6d61a9c9be601bfb68a3cc: The parameter is incorrect.: unknown
    --- FAIL: TestWaitNonBlocked/wait-nonblocking-exit-random (1.64s)

=== FAIL: github.com/docker/docker/integration/container TestWaitNonBlocked (0.02s)

@thaJeztah thaJeztah marked this pull request as ready for review August 22, 2022 15:46
Copy link
Contributor

@corhere corhere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason to keep contrib/download-frozen-image-v2.sh around?

@thaJeztah
Copy link
Member Author

Is there any reason to keep contrib/download-frozen-image-v2.sh around?

No strong reason, other than that, at some point, it was used by many Kubernetes users to load images in their cluster. That said, I think someone already forked it as a standalone project, so perhaps it's fine to remove as well (it's a nice "reference" though on "how pull works").

@crazy-max
Copy link
Member

Is there any reason to keep contrib/download-frozen-image-v2.sh around?

Yeah we can remove download-frozen-image-v2.sh script in follow-up but needs to look first at Dockerfile.e2e which seems not used anymore in our pipeline. Didn't want to add too much refactoring in #43529

@thaJeztah
Copy link
Member Author

@tianon this lgty?

@thaJeztah
Copy link
Member Author

Discussed in the maintainers meeting, and possibly we can fix the same issue by adjusting the bash-script to take variant into account; @crazy-max will have a look if that's an option

@neersighted
Copy link
Member

Closed in favor of the approach in #44114.

@thaJeztah thaJeztah removed this from the v-next milestone Sep 21, 2022
@thaJeztah thaJeztah deleted the frozen_skopeo branch October 28, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants