Dockerfile: use TARGETPLATFORM with scopeo for frozen images stage#44005
Dockerfile: use TARGETPLATFORM with scopeo for frozen images stage#44005thaJeztah wants to merge 1 commit intomoby:masterfrom
Conversation
frozen-images stage doesn't use the download-frozen-image-v2.sh anymore so we can effectively use TARGETPLATFORM from global scope. The test util has been updated accordingly. In a follow-up we can remove download-frozen-image-v2.sh script but needs to look first at Dockerfile.e2e which seems not used anymore in our pipeline. Signed-off-by: CrazyMax <[email protected]>
|
Interesting; doesn't look related, but not sure I've seen this particular error before (integration-test (windows-2022, containerd, |
corhere
left a comment
There was a problem hiding this comment.
Is there any reason to keep contrib/download-frozen-image-v2.sh around?
No strong reason, other than that, at some point, it was used by many Kubernetes users to load images in their cluster. That said, I think someone already forked it as a standalone project, so perhaps it's fine to remove as well (it's a nice "reference" though on "how pull works"). |
Yeah we can remove download-frozen-image-v2.sh script in follow-up but needs to look first at Dockerfile.e2e which seems not used anymore in our pipeline. Didn't want to add too much refactoring in #43529 |
|
@tianon this lgty? |
|
Discussed in the maintainers meeting, and possibly we can fix the same issue by adjusting the bash-script to take variant into account; @crazy-max will have a look if that's an option |
|
Closed in favor of the approach in #44114. |
frozen-images stage doesn't use the download-frozen-image-v2.sh
anymore so we can effectively use TARGETPLATFORM from global scope.
The test util has been updated accordingly.
In a follow-up we can remove download-frozen-image-v2.sh script but
needs to look first at Dockerfile.e2e which seems not used anymore
in our pipeline.
- A picture of a cute animal (not mandatory but encouraged)