[22.06 backport] don't use canceled context to send KILL signal to healthcheck process#43994
Merged
Merged
Conversation
Member
|
temporarily moving to draft as #43739 was updated |
thaJeztah
force-pushed
the
backport-22.06/healthcheck_timeout
branch
from
e512033 to
42003e1
Compare
Terminating the exec process when the context is canceled has been broken since Docker v17.11 so nobody has been able to depend upon that behaviour in five years of releases. We are thus free from backwards- compatibility constraints. Co-authored-by: Nicolas De Loof <[email protected]> Co-authored-by: Sebastiaan van Stijn <[email protected]> Signed-off-by: Nicolas De Loof <[email protected]> Signed-off-by: Cory Snider <[email protected]> Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit 4b84a33) Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
backport-22.06/healthcheck_timeout
branch
from
42003e1 to
e7f4963
Compare
Member
|
re-did the cherry-pick with the commit that was merged in #43739 |
Member
|
This was a clean cherry-pick; bringing this one in |
thaJeztah
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clean cherry-pick