Skip to content

[22.06] Allow containerd shim refs in default-runtime#43993

Merged
thaJeztah merged 1 commit into
moby:22.06from
cpuguy83:22.06_backport_43978_default_runtime
Aug 18, 2022
Merged

[22.06] Allow containerd shim refs in default-runtime#43993
thaJeztah merged 1 commit into
moby:22.06from
cpuguy83:22.06_backport_43978_default_runtime

Conversation

@cpuguy83
Copy link
Copy Markdown
Member

Cherry-pick of #43978


Since runtimes can now just be containerd shims, we need to check if the
reference is possibly a containerd shim.

Signed-off-by: Brian Goff [email protected]
(cherry picked from commit e6ee27a)
Signed-off-by: Brian Goff [email protected]

Since runtimes can now just be containerd shims, we need to check if the
reference is possibly a containerd shim.

Signed-off-by: Brian Goff <[email protected]>
(cherry picked from commit e6ee27a)
Signed-off-by: Brian Goff <[email protected]>
@cpuguy83 cpuguy83 requested review from corhere and thaJeztah August 18, 2022 18:52
@thaJeztah thaJeztah added area/runtime Runtime status/2-code-review kind/feature Functionality or other elements that the project doesn't currently have. Features are new and shiny impact/changelog docs/revisit area/daemon Core Engine labels Aug 18, 2022
@thaJeztah thaJeztah added this to the 22.06.0 milestone Aug 18, 2022
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 1e6029e into moby:22.06 Aug 18, 2022
@cpuguy83 cpuguy83 deleted the 22.06_backport_43978_default_runtime branch August 18, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/daemon Core Engine area/runtime Runtime docs/revisit impact/changelog kind/feature Functionality or other elements that the project doesn't currently have. Features are new and shiny status/2-code-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants