libcontainerd: switch generated containerd.toml to v2 (v1 is deprecated)#43872
Merged
thaJeztah merged 1 commit intomoby:masterfrom Jul 28, 2022
Merged
libcontainerd: switch generated containerd.toml to v2 (v1 is deprecated)#43872thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
Before this patch:
INFO[2022-07-27T14:30:06.188762628Z] Starting up
INFO[2022-07-27T14:30:06.190750725Z] libcontainerd: started new containerd process pid=2028
...
WARN[0000] containerd config version `1` has been deprecated and will be removed in containerd v2.0, please switch to version `2`, see https://github.com/containerd/containerd/blob/main/docs/PLUGINS.md#version-header
INFO[2022-07-27T14:30:06.220024286Z] starting containerd revision=10c12954828e7c7c9b6e0ea9b0c02b01407d3ae1 version=v1.6.6
With this patch:
INFO[2022-07-27T14:28:04.025543517Z] Starting up
INFO[2022-07-27T14:28:04.027447105Z] libcontainerd: started new containerd process pid=1377
...
INFO[2022-07-27T14:28:04.054483270Z] starting containerd revision=10c12954828e7c7c9b6e0ea9b0c02b01407d3ae1 version=v1.6.6
And the generated /var/run/docker/containerd/containerd.toml:
```toml
disabled_plugins = ["io.containerd.grpc.v1.cri"]
imports = []
oom_score = 0
plugin_dir = ""
required_plugins = []
root = "/var/lib/docker/containerd/daemon"
state = "/var/run/docker/containerd/daemon"
temp = ""
version = 2
[cgroup]
path = ""
[debug]
address = "/var/run/docker/containerd/containerd-debug.sock"
format = ""
gid = 0
level = "debug"
uid = 0
[grpc]
address = "/var/run/docker/containerd/containerd.sock"
gid = 0
max_recv_message_size = 16777216
max_send_message_size = 16777216
tcp_address = ""
tcp_tls_ca = ""
tcp_tls_cert = ""
tcp_tls_key = ""
uid = 0
[metrics]
address = ""
grpc_histogram = false
[plugins]
[proxy_plugins]
[stream_processors]
[timeouts]
[ttrpc]
address = ""
gid = 0
uid = 0
```
Signed-off-by: Sebastiaan van Stijn <[email protected]>
AkihiroSuda
approved these changes
Jul 28, 2022
corhere
approved these changes
Jul 28, 2022
Member
Author
|
Thanks! Let me get this one in 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this patch:
With this patch:
And the generated /var/run/docker/containerd/containerd.toml:
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)