fix: When executing cli.setuphijackconn, call cli.dialer () after exe…#43801
Closed
yunnet wants to merge 6 commits intomoby:masterfrom
Closed
fix: When executing cli.setuphijackconn, call cli.dialer () after exe…#43801yunnet wants to merge 6 commits intomoby:masterfrom
yunnet wants to merge 6 commits intomoby:masterfrom
Conversation
…cuting "dialer := cli.dialer ()", TLSClientConfig is not null when Scheme =" HTTP ", causing an error. The error message is: OCI runtime exec failed: exec failed: unable to start container process: cannot connect to the Docker daemon. Is 'docker daemon' running on this host?
Member
|
Thanks, but please sign the commit for DCO (run |
thaJeztah
added
status/2-code-review
dco/no
thaJeztah
reviewed
Jul 13, 2022
Comment on lines
+314
to
+316
| if cli.scheme == "http" { | ||
| transport.TLSClientConfig = nil | ||
| } |
Member
There was a problem hiding this comment.
@AkihiroSuda I'm wondering what the root cause is of this; I had a quick look at some of the code, and looking at
Lines 146 to 158 in 0910306
That appears to change scheme to https if TLS Config was found; is something wrong with the initialisation code?
…cuting "dialer := cli.dialer ()", TLSClientConfig is not null when Scheme =" HTTP ", causing an error. The error message is: OCI runtime exec failed: exec failed: unable to start container process: cannot connect to the Docker daemon. Is 'docker daemon' running on this host? Signed-off-by: yunnet <[email protected]>
Member
|
I suggest closing this one, the code has changed and this might not be relevant anymore |
Member
|
Thanks for looking; let me close this one 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…cuting "dialer := cli.dialer ()",
TLSClientConfig is not null when Scheme =" HTTP ", causing an error.
The error message is: OCI runtime exec failed: exec failed: unable to start container process: cannot connect to the Docker daemon. Is 'docker daemon' running on this host?
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)