fix flaky TestRunContainerWithRmFlag tests#43681
Merged
tianon merged 1 commit intomoby:masterfrom Jun 2, 2022
Merged
Conversation
This attempts to fix CI flakiness on the TestRunContainerWithRmFlagCannotStartContainer and TestRunContainerWithRmFlagExitCodeNotEqualToZero tests. These tests; - get a list of all container ID's - run a container with `--rm` - wait for it to exit - checks that the list of all container IDs is empty The last step assumes that no other tests are running on the same daemon; if another test is running, there may be other containers present (unrelated to the test). This patch updates the tests to use a `docker inspect` to verify the container no longer exists afterwards. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Member
Author
|
And of course it failed on two other flaky tests, but not the one I fixed 🥳 |
Member
Author
|
Ah, boo; CRIU repo is down indeed; |
Member
Author
|
@rumpl @tianon @crazy-max ptal |
crazy-max
approved these changes
Jun 2, 2022
tianon
approved these changes
Jun 2, 2022
Member
Member
Author
|
Ah, dang. I guess it's just slowness on Windows then; thinking of it; the Some possible options;
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This attempts to fix CI flakiness on the TestRunContainerWithRmFlagCannotStartContainer
and TestRunContainerWithRmFlagExitCodeNotEqualToZero tests.
These tests;
--rmThe last step assumes that no other tests are running on the same daemon; if
another test is running, there may be other containers present (unrelated to
the test).
This patch updates the tests to use a
docker inspectto verify the containerno longer exists afterwards.
Signed-off-by: Sebastiaan van Stijn [email protected]
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)