Ensure performance tuning is always applied#43670
Merged
thaJeztah merged 1 commit intomoby:masterfrom May 31, 2022
Merged
Conversation
Previously, with the patch from moby#43146, it was possible for a network configured with a single ingress or load balancer on a distribution which does not have the `ip_vs` kernel module loaded by default to try to apply sysctls which did not exist yet, and subsequently dynamically load the module as part of ipvs/netlink.go. This module is vendored, and not a great place to try to tie back into core libnetwork functionality, so also ensure that the sysctls (which are idempotent) are called after ingress/lb creation once `ipvs` has been initialized. Signed-off-by: Ryan Barry <[email protected]>
corhere
approved these changes
May 31, 2022
Member
|
All green now; bringing this in; thanks! |
evol262
pushed a commit
to evol262/libnetwork
that referenced
this pull request
May 31, 2022
Pull moby/moby#43146 and moby/moby#43670 into 20.10 relates to #35082, moby#2491 Previously, values for expire_quiescent_template, conn_reuse_mode, and expire_nodest_conn were set only system-wide. Also apply them for new lb_* and ingress_sbox sandboxes, so they are appropriately propagated Signed-off-by: Ryan Barry <[email protected]>
evol262
pushed a commit
to evol262/libnetwork
that referenced
this pull request
May 31, 2022
Pull moby/moby#43146 and moby/moby#43670 into 20.10 relates to #35082, moby#2491 Previously, values for expire_quiescent_template, conn_reuse_mode, and expire_nodest_conn were set only system-wide. Also apply them for new lb_* and ingress_sbox sandboxes, so they are appropriately propagated Signed-off-by: Ryan Barry <[email protected]>
evol262
pushed a commit
to evol262/libnetwork
that referenced
this pull request
May 31, 2022
Pull moby/moby#43146 and moby/moby#43670 into 20.10 relates to #35082, moby#2491 Previously, values for expire_quiescent_template, conn_reuse_mode, and expire_nodest_conn were set only system-wide. Also apply them for new lb_* and ingress_sbox sandboxes, so they are appropriately propagated Signed-off-by: Ryan Barry <[email protected]>
evol262
pushed a commit
to evol262/libnetwork
that referenced
this pull request
Jun 1, 2022
Pull moby/moby#43146 and moby/moby#43670 into 20.10 relates to #35082, moby#2491 Previously, values for expire_quiescent_template, conn_reuse_mode, and expire_nodest_conn were set only system-wide. Also apply them for new lb_* and ingress_sbox sandboxes, so they are appropriately propagated Signed-off-by: Ryan Barry <[email protected]> Co-authored-by: Bjorn Neergaard <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, with the patch from #43146, it was possible for a
network configured with a single ingress or load balancer on a
distribution which does not have the
ip_vskernel module loadedby default to try to apply sysctls which did not exist yet, and
subsequently dynamically load the module as part of ipvs/netlink.go.
This module is vendored, and not a great place to try to tie back
into core libnetwork functionality, so also ensure that the sysctls
(which are idempotent) are called after ingress/lb creation once
ipvshas been initialized.Signed-off-by: Ryan Barry [email protected]