ci(windows): upload test reports with logs#43665
Conversation
|
Are we able to do the same for Linux, or are we already doing that? Note that (especially in Linux CI), there will be multiple logs, and they've been organised (at least for the |
|
Structure is slightly different between some of the Linux stages (as the Details |
Linux tests with GitHub Actions would be for a follow-up of #43529. See crazy-max/moby@cross...crazy-max:cross-test-workflow. For But yes it will have the same layout in GHA too. |
|
Thanks! Sorry for asking (didn't take the time to dig in the results 😅, and thought you'd know from the top of your head) |
|
@thaJeztah Ready for review, let me know if reports lgty: https://github.com/moby/moby/actions/runs/2414212763 |
|
Looking good! I found two minor issues;
So perhaps we need to have an |
|
I guess this is missing some lines moby/.github/workflows/windows.yml Lines 351 to 355 in 235f862 if I compare it with moby/hack/make/.integration-test-helpers Lines 86 to 89 in 7b9275c ( |
Don't think we can as containerd is now started as a service and not as a process: Lines 637 to 640 in 4e09933 For daemon logs I think we can tweak the windows events filter to split logs. We could do that for containerd too but I don't think containerd manifests message table entries for Windows Event Logging yet like dockerd.
Yes indeed looks missing for |
Ah, right, hm.. yeah, guess that's a "meh" then |
bb99c58 to
3a2c348
Compare
thaJeztah
left a comment
There was a problem hiding this comment.
🤐 🙈 😂
looks like you reverted the rename of those files 😅
|
Let me push a quick fix for those so that Ci can run |
Signed-off-by: CrazyMax <[email protected]> Signed-off-by: Sebastiaan van Stijn <[email protected]>
|
Thanks for answering the question! (Good question, @samuelkarp!) Test failures are in Jenkins, and unrelated to this PR; let's get this one in 👍 |
As discussed with @thaJeztah, before disabling Windows nodes on Jenkins we need to keep logs in uploaded reports.
Signed-off-by: CrazyMax [email protected]