Fix for Windows port conflict with published ports in host mode for overlay. #43634
Conversation
Signed-off-by: Ameya Gawde <[email protected]>
thaJeztah
added
platform/windows
status/2-code-review
area/networking
|
Curious; Does the same approach work for older versions of Windows (RS5?) or is it just ignored on those? |
It doesn't regress the old versions of Windows (pre Aug2020-RS5/RS1). The flag is ignored. |
|
Looking into |
|
|
|
Ah, sure; gave it a kick |
|
Windows CI is green now. The earlier Windows failed test seems to be flaky. |
d66c0d6 to
adea710
Compare
Signed-off-by: Ameya Gawde <[email protected]>
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM (sorry, thought I already did when I kicked CI 🙈)
|
All green; codecov check seems broken, so ignoring that one |
@ameyag did you got information from Microsoft about which KB should include that patch? People are still complaining about this issue with Docker version which should contain this fix #42811 (comment) |
|
It was supposed to be released today but the recent ETA I received from Microsoft is 2pm PST July 26. |
5 participants
- What I did
The libnetwork logic uses a dummy proxy to bind the ports for communication between container and host. WS 2019 Aug 2020 patch onwards, Windows started doing an early port reservation which conflicts with the aforementioned logic for overlay and host publish mode for the ports. The bug is now applicable to current patched Windows >= WS 2019. Thus, making a change to address the race with recent changes on the Windows side.
Fixes: #42811
cc @dcantah @kestratt
- How I did it
Full Changelog: microsoft/hcsshim@v0.9.2...v0.9.3
ExternalPortReservedto true inConvertPortBindingsfor dummy proxy to avoid the reservation on OS side.- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)