Skip to content

fix docker-proxy not statically linked#43621

Merged
thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah:fix_userland_proxy_static
May 20, 2022
Merged

fix docker-proxy not statically linked#43621
thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah:fix_userland_proxy_static

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented May 20, 2022

Partial carry of #43492, but only taking the first 2 commits

@thaJeztah thaJeztah mentioned this pull request May 20, 2022
Closed
@thaJeztah thaJeztah added this to the 22.06.0 milestone May 20, 2022
@thaJeztah thaJeztah changed the title fix docker-proxy statically linked fix docker-proxy not statically linked May 20, 2022
@thaJeztah
Copy link
Member Author

thaJeztah commented May 20, 2022

No segfaults now I think, but one failure that could still be genuine;

 === FAIL: libnetwork/drivers/bridge TestQueryEndpointInfo (0.39s)
[2022-05-20T08:50:20.869Z] time="2022-05-20T08:47:47Z" level=warning msg="bridge store not initialized. kv object docker/network/v1.0/bridge/net1/ is not added to the store"
[2022-05-20T08:50:20.869Z] time="2022-05-20T08:47:47Z" level=warning msg="bridge store not initialized. kv object docker/network/v1.0/bridge-endpoint/ep1/ is not added to the store"
[2022-05-20T08:50:20.869Z] time="2022-05-20T08:47:47Z" level=warning msg="Failed to allocate and map port 23000-23000: Error starting userland proxy: "
[2022-05-20T08:50:20.869Z]     bridge_test.go:665: Failed to program external connectivity: Error starting userland proxy:

@thaJeztah
Copy link
Member Author

thaJeztah commented May 20, 2022

The other failure is a known flaky;

=== RUN   TestDockerSwarmSuite/TestSwarmLockUnlockCluster
    docker_cli_swarm_test.go:1112: [deafd89436346] joining swarm manager [d98c044a4dea8]@0.0.0.0:2477, swarm listen addr 0.0.0.0:2478
    docker_cli_swarm_test.go:1113: [d1f5c6938d03f] joining swarm manager [d98c044a4dea8]@0.0.0.0:2477, swarm listen addr 0.0.0.0:2479
    docker_cli_swarm_test.go:1001: timeout hit after 1s: first check never completed
    daemon_swarm.go:162: assertion failed: error is not nil: error during connect: Get "http://%2Ftmp%2Fdocker-integration%2Fd98c044a4dea8.sock/v1.42/info": EOF: get swarm info
    --- FAIL: TestDockerSwarmSuite/TestSwarmLockUnlockCluster (66.10s)

@thaJeztah
Copy link
Member Author

thaJeztah commented May 20, 2022

Linux tests completed, I kicked off another run to check if the first one was just a flaky, or an actual issue #43621 (comment)

@thaJeztah thaJeztah force-pushed the fix_userland_proxy_static branch from 1c3ceb2 to 3823d57 Compare May 20, 2022 11:29
@crazy-max @thaJeztah
fix docker-proxy not statically linked
493d3ca 
Signed-off-by: CrazyMax <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah force-pushed the fix_userland_proxy_static branch from 3823d57 to 493d3ca Compare May 20, 2022 11:54
@thaJeztah thaJeztah marked this pull request as ready for review May 20, 2022 14:25
@thaJeztah thaJeztah requested a review from tianon as a code owner May 20, 2022 14:25
crazy-max
crazy-max approved these changes May 20, 2022
View reviewed changes
Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member Author

thaJeztah commented May 20, 2022

thx! I'll merge this so that we have at least a static binary that runs on alpine, and doesn't SEGFAULT 😂

We'll do further improvements later

@thaJeztah thaJeztah merged commit 8abb84c into moby:master May 20, 2022
@thaJeztah thaJeztah deleted the fix_userland_proxy_static branch May 20, 2022 15:57
@chadlwilson chadlwilson mentioned this pull request Sep 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crazy-max crazy-max crazy-max approved these changes

@tianon tianon Awaiting requested review from tianon tianon is a code owner

Assignees

No one assigned

Labels

area/packaging status/2-code-review

Projects

None yet

Milestone

23.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@thaJeztah @crazy-max