client: ContainerKill(): don't send signal query-param if none was set#43503
Merged
samuelkarp merged 1 commit intomoby:masterfrom Apr 20, 2022
Merged
client: ContainerKill(): don't send signal query-param if none was set#43503samuelkarp merged 1 commit intomoby:masterfrom
samuelkarp merged 1 commit intomoby:masterfrom
Conversation
Just a small clean-up (there's more endpoints to do this for, but I was working on changes in this area on the CLI when I noticed we were setting this query-parameter unconditionally. Signed-off-by: Sebastiaan van Stijn <[email protected]>
tianon
approved these changes
Apr 20, 2022
samuelkarp
approved these changes
Apr 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a small clean-up (there's more endpoints to do this for, but I was working on changes in this area on the CLI when I noticed we were setting this query-parameter unconditionally.
- A picture of a cute animal (not mandatory but encouraged)