[WIP] Separate static binary for chrootarchive#43186
Closed
corhere wants to merge 1 commit intomoby:masterfrom
Closed
[WIP] Separate static binary for chrootarchive#43186corhere wants to merge 1 commit intomoby:masterfrom
corhere wants to merge 1 commit intomoby:masterfrom
Conversation
Contributor
Author
|
@tonistiigi @thaJeztah @kolyshkin @cpuguy83 what do you think of this solution? A new binary would be required on *nix platforms, which will impact everyone packaging Docker; is this an acceptable tradeoff? |
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An implementation of #42402 (comment) to solicit feedback before polishing it up, integrating into the build scripts and fixing tests.
Safety is assured, as much as possible, by ensuring that the binary which chroots into container filesystems is statically linked, with no libc to introduce vulnerabilities as side-effects.
go buildwill fail if cgo is enabledTo try it out,
and copy the binary into a directory on your $PATH.