Skip to content

oci.DeviceFromPath() switch to use containerd implementation#43055

Merged
samuelkarp merged 1 commit intomoby:masterfrom
thaJeztah:use_containerd_oci_devices_part2
Oct 7, 2022
Merged

oci.DeviceFromPath() switch to use containerd implementation#43055
samuelkarp merged 1 commit intomoby:masterfrom
thaJeztah:use_containerd_oci_devices_part2

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Dec 1, 2021

@thaJeztah thaJeztah added area/runtime Runtime status/2-code-review kind/refactor PR's that refactor, or clean-up code labels Dec 1, 2021
@thaJeztah thaJeztah force-pushed the use_containerd_oci_devices_part2 branch from 85d9268 to c260f37 Compare December 2, 2021 17:59
@thaJeztah thaJeztah force-pushed the use_containerd_oci_devices_part2 branch from c260f37 to b357140 Compare January 6, 2022 17:48
@thaJeztah thaJeztah force-pushed the use_containerd_oci_devices_part2 branch from b357140 to bd3496c Compare March 26, 2022 19:11
@thaJeztah thaJeztah force-pushed the use_containerd_oci_devices_part2 branch from bd3496c to db9e4e4 Compare September 27, 2022 19:17
@thaJeztah thaJeztah marked this pull request as ready for review September 27, 2022 20:36
@thaJeztah
Copy link
Copy Markdown
Member Author

@corhere @AkihiroSuda ptal

Reducing the amount of code used from runc/libcontainer

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah force-pushed the use_containerd_oci_devices_part2 branch from db9e4e4 to b44b319 Compare September 29, 2022 08:40
@thaJeztah
Copy link
Copy Markdown
Member Author

rebased after #44211 was merged (white-space change in adjacent line)

@thaJeztah
Copy link
Copy Markdown
Member Author

@cpuguy83 PTAL

@samuelkarp samuelkarp merged commit 968a0bc into moby:master Oct 7, 2022
@thaJeztah thaJeztah changed the title oci.DevicesFromPath() switch to use containerd implementation oci.DeviceFromPath() switch to use containerd implementation Oct 9, 2022
@thaJeztah thaJeztah deleted the use_containerd_oci_devices_part2 branch October 22, 2022 22:26
@neersighted neersighted added this to the v-next milestone Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/runtime Runtime kind/refactor PR's that refactor, or clean-up code status/4-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants