daemon.WithDevices(): use containerd's HostDevices()#43053
Merged
thaJeztah merged 1 commit intomoby:masterfrom Jan 5, 2022
Merged
daemon.WithDevices(): use containerd's HostDevices()#43053thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
thaJeztah
added
area/runtime
Trying to reduce the use of libcontainer/devices, as it's considered to be an "internal" package by runc. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
use_containerd_oci_devices
branch
from
39a70aa to
9d9b8e0
Compare
Member
Author
|
@AkihiroSuda @cpuguy83 ptal |
tianon
approved these changes
Jan 5, 2022
samuelkarp
approved these changes
Jan 5, 2022
Member
Author
|
3 LGTM's should probably be enough 😅 let me get this one in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to reduce the use of libcontainer/devices, as it's considered to be an "internal" package by runc.
--privilegedrootless containers #42638 (comment)