Skip to content

vendor: github.com/Microsoft/hcsshim v0.8.22 #42993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cpuguy83 merged 1 commit into from
Nov 18, 2021
Merged

vendor: github.com/Microsoft/hcsshim v0.8.22 #42993

cpuguy83 merged 1 commit into from
Nov 18, 2021

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Nov 5, 2021

No significant changes for our vendored code, but reverts back containerd minimal
dependency to v1.4.9.

full diff: microsoft/hcsshim@v0.8.20...v0.8.22

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah
vendor: github.com/Microsoft/hcsshim v0.8.22
c97d09b 
No significant changes for our vendored code, but reverts back containerd minimal
dependency to v1.4.9.

full diff: microsoft/hcsshim@v0.8.20...v0.8.22

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah added this to the 21.xx milestone Nov 5, 2021
@tianon
Copy link
Member

tianon commented Nov 8, 2021 

=== FAIL: cmd/docker-proxy TestSCTP4Proxy (0.29s)
2021/11/05 14:07:50 Can't forward traffic to backend sctp/127.0.0.1:34208: transport endpoint is already connected

@thaJeztah
Copy link
Member Author

thaJeztah commented Nov 9, 2021

Unable to delete '/home/ubuntu/workspace/moby_PR-42987'. Tried 3 times (of a maximum of 3) waiting 0.1 sec between attempts. (Discarded 9 additional exceptions)

For those reading along; that one is tracked through #42974, and I was trying to debug in #42995

@thaJeztah thaJeztah mentioned this pull request Nov 11, 2021
Open
@thaJeztah
Copy link
Member Author

thaJeztah commented Nov 11, 2021

Failure on Windows (flaky test?); opened #43012

=== RUN   TestDockerSuite/TestSlowStdinClosing
    docker_cli_run_test.go:4177: assertion failed: error is not nil: exit status 127
    --- FAIL: TestDockerSuite/TestSlowStdinClosing (0.92s)

@thaJeztah thaJeztah mentioned this pull request Nov 17, 2021
Merged
cpuguy83
cpuguy83 approved these changes Nov 18, 2021
View reviewed changes
Copy link
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpuguy83 cpuguy83 merged commit 78fd4d3 into moby:master Nov 18, 2021
samuelkarp
samuelkarp approved these changes Nov 18, 2021
View reviewed changes
Copy link
Member

@samuelkarp samuelkarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah deleted the bump_hcsshim branch November 18, 2021 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tianon tianon tianon approved these changes

@samuelkarp samuelkarp samuelkarp approved these changes

@cpuguy83 cpuguy83 cpuguy83 approved these changes

Assignees

No one assigned

Labels

status/2-code-review

Projects

None yet

Milestone

23.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah @tianon @samuelkarp @cpuguy83