vendor: github.com/moby/sys/mount v0.3.0, mountinfo v0.5.0, signal v0.6.0, symlink v0.2.0#42980
vendor: github.com/moby/sys/mount v0.3.0, mountinfo v0.5.0, signal v0.6.0, symlink v0.2.0#42980thaJeztah merged 2 commits intomoby:masterfrom
Conversation
|
CI is happy with this update (besides the Jenkins workspace cleanup, but that's a known issue) We can look into adding more code to change the error handling, but at least all tests still pass |
thaJeztah
changed the title
| err := client.ContainerKill(ctx, id, "0") | ||
| assert.Error(t, err, "Error response from daemon: Invalid signal: 0") | ||
| assert.ErrorContains(t, err, "Error response from daemon:") | ||
| assert.ErrorContains(t, err, "nvalid signal: 0") |
There was a problem hiding this comment.
Should this be "nvalid" or "invalid"?
There was a problem hiding this comment.
ah, so this was a little hack; the update has some linting fixes, one of them is "errors should not be capitalised or contain interpunction" so it changed from Invalid signal to invalid signal. Tried to keep it "portable" without doing a string.ToLower(). Probably not strictly needed (in case we wanted to run the integration tests against different daemon versions, but I guess we won't be doing that)
There was a problem hiding this comment.
That'd be worth a comment if you're inclined to make a minor fix here.
There was a problem hiding this comment.
I rebased, and added a comment 👍
full diff: golang/sys@63515b4...69cdffd Signed-off-by: Sebastiaan van Stijn <[email protected]>
….6.0, symlink v0.2.0 full diff: moby/sys@signal/v0.5.0...signal/v0.6.0 Modules: - github.com/moby/sys/mount v0.3.0 - github.com/moby/sys/mountinfo v0.5.0 - github.com/moby/sys/signal v0.6.0 - github.com/moby/sys/symlink v0.2.0 Signed-off-by: Sebastiaan van Stijn <[email protected]>
|
Failure on Windows is unrelated (known flaky test) |
|
let me bring this one in |
3 participants
vendor: golang.org/x/sys v0.0.0-20211025201205-69cdffdb9359
full diff: golang/sys@63515b4...69cdffd
vendor: github.com/moby/sys/mount v0.3.0, mountinfo v0.5.0, signal v0.6.0, symlink v0.2.0
full diff: moby/sys@signal/v0.5.0...signal/v0.6.0
Modules: