Skip to content

[20.10] vendor: Update go-winio to v0.4.20#42944

Merged
thaJeztah merged 1 commit into
moby:20.10from
kevpar:20.10_update-winio
Oct 18, 2021
Merged

[20.10] vendor: Update go-winio to v0.4.20#42944
thaJeztah merged 1 commit into
moby:20.10from
kevpar:20.10_update-winio

Conversation

@kevpar

@kevpar kevpar commented Oct 15, 2021

Copy link
Copy Markdown
Contributor

Updates go-winio to the latest v0.4.x version. The main important fix
here is to go-winio's backuptar package. This is needed to fix a bug in
sparse file handling in container layers, which was exposed by a recent
change in Windows.

go-winio v0.4.20: https://github.com/microsoft/go-winio/releases/tag/v0.4.20

There is a similar PR to master to update to go-winio v0.5.1 (#42943).
However for 20.10 we need to stay on v0.4.x versions as they avoid a
breaking change.

Signed-off-by: Kevin Parsons [email protected]

Updates go-winio to the latest v0.4.x version. The main important fix
here is to go-winio's backuptar package. This is needed to fix a bug in
sparse file handling in container layers, which was exposed by a recent
change in Windows.

go-winio v0.4.20: https://github.com/microsoft/go-winio/releases/tag/v0.4.20

Signed-off-by: Kevin Parsons <[email protected]>
@kevpar
kevpar force-pushed the 20.10_update-winio branch from fc15107 to c2b9a32 Compare October 15, 2021 22:24
@kevpar
kevpar marked this pull request as ready for review October 15, 2021 22:30
@thaJeztah thaJeztah added this to the 20.10.10 milestone Oct 17, 2021

@thaJeztah thaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah

Copy link
Copy Markdown
Member

@AkihiroSuda @cpuguy83 PTAL

@thaJeztah

Copy link
Copy Markdown
Member

CI failures are unrelated (tracked through #41930 and #42892)

=== RUN   TestHealthKillContainer
    health_test.go:62: timeout hit after 10s: waiting for container to become healthy
--- FAIL: TestHealthKillContainer (12.43s)

@thaJeztah

Copy link
Copy Markdown
Member

Bringing this one in

@thaJeztah
thaJeztah merged commit 9f5b26f into moby:20.10 Oct 18, 2021
@kevpar

kevpar commented Oct 19, 2021

Copy link
Copy Markdown
Contributor Author

Somehow missed the emails that this got in. Thanks folks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants