hack/vendor.sh: allow go version to be specified with .0#42779
Merged
thaJeztah merged 1 commit intomoby:masterfrom Aug 23, 2021
Merged
hack/vendor.sh: allow go version to be specified with .0#42779thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
tianon
reviewed
Aug 23, 2021
hack/vendor.sh
Outdated
Comment on lines
20
to
21
Member
There was a problem hiding this comment.
We probably want this to be specific to just the trailing .0 so we don't drop patch releases, right?
Suggested change
| echo "downloading: https://golang.org/dl/go${GO_VERSION%.*}.src.tar.gz" | |
| curl -fsSL "https://golang.org/dl/go${GO_VERSION%.*}.src.tar.gz" \ | |
| echo "downloading: https://golang.org/dl/go${GO_VERSION%.0}.src.tar.gz" | |
| curl -fsSL "https://golang.org/dl/go${GO_VERSION%.0}.src.tar.gz" \ |
Member
Author
There was a problem hiding this comment.
Ah, thanks! I always struggle with these and forget the correct syntax, LOL. Yup, that's what my intent was
Golang '.0' releases are released without a trailing .0 (i.e. go1.17
is equal to go1.17.0). For the base image, we want to specify the go
version including their patch release (golang:1.17 is equivalent to
go1.17.x), so adjust the script to also accept the trailing .0, because
otherwise the download-URL is not found:
hack/vendor.sh archive/tar
update vendored copy of archive/tar
downloading: https://golang.org/dl/go1.17.0.src.tar.gz
curl: (22) The requested URL returned error: 404
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
fix_hack_vendor
branch
from
db15b9d to
9ed88a0
Compare
Member
Author
|
Fixed! PTAL |
AkihiroSuda
approved these changes
Aug 23, 2021
tianon
approved these changes
Aug 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Golang '.0' releases are released without a trailing .0 (i.e. go1.17
is equal to go1.17.0). For the base image, we want to specify the go
version including their patch release (golang:1.17 is equivalent to
go1.17.x), so adjust the script to also accept the trailing .0, because
otherwise the download-URL is not found:
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)