Merged
Conversation
Member
Author
|
🤦 Forgot to |
thaJeztah
force-pushed
the
update_go_1.17
branch
from
fff1513 to
2c9aaf1
Compare
thaJeztah
force-pushed
the
update_go_1.17
branch
from
2c9aaf1 to
3fb878b
Compare
thaJeztah
requested review from
cpuguy83,
johnstep and
tonistiigi
as code owners
AkihiroSuda
approved these changes
Aug 23, 2021
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
update_go_1.17
branch
from
3fb878b to
aa60630
Compare
Member
Author
|
Rebased, because #41479 was merged, which changed adjacent lines in |
Member
Author
|
@tianon @cpuguy83 @tonistiigi PTAL |
tianon
approved these changes
Aug 26, 2021
Member
tianon
left a comment
tianon
left a comment
There was a problem hiding this comment.
LGTM (but to be explicit, I am against backporting this to 20.10)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening as draft to see if things explode
Depends on:
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)