info: remove "expected" check for tini version#42776
Conversation
These checks were added when we required a specific version of containerd and runc (different versions were known to be incompatible). I don't think we had a similar requirement for tini, so this check was redundant. Let's remove the check altogether. Signed-off-by: Sebastiaan van Stijn <[email protected]>
| v.RuncCommit.ID = "N/A" | ||
| v.ContainerdCommit.ID = "N/A" | ||
| v.InitCommit.ID = "N/A" |
There was a problem hiding this comment.
Bit on the fence if we need to keep the N/A value on the server-side, or if we should move this to the cli. I'd love to move it there, but will have to think if there could be a breaking change because of that.
I might still do so in a follow-up though 😅
tianon
left a comment
tianon
left a comment
There was a problem hiding this comment.
LGTM; too bad we can't drop the Expected fields altogether 😅
maybe we can. I want to have a look at that. At least check if we can set them to an empty string (which wouldn't return it in the response I guess). If that doesn't break older clients, we could drop them. |
|
Answering myself; I guess we can't remove them if we have a version, and only if we don't have a version (the N/A case). We could drop the based on API version though (omit them on API >= 1.42) 🤔 |
3 participants
These checks were added when we required a specific version of containerd
and runc (different versions were known to be incompatible). I don't think
we had a similar requirement for tini, so this check was redundant. Let's
remove the check altogether.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)