testutil: don't import "opts" package#42757
Merged
tianon merged 1 commit intomoby:masterfrom Aug 20, 2021
Merged
Conversation
It was only used for two consts, which are unlikely to change, but the "opts" package currently also imports libnetwork/ipamutils, which has an `init()` function that does some heavy lifting, and not needed for this utility's purpose. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
area/testing
kind/refactor
thaJeztah
added a commit
to thaJeztah/buildkit
that referenced
this pull request
Aug 18, 2021
USING https://github.com/thaJeztah/docker/tree/TEMP_CLEANED_DOCKER branch, which includes moby/moby#42755 and moby/moby#42757 Signed-off-by: Sebastiaan van Stijn <[email protected]>
AkihiroSuda
approved these changes
Aug 19, 2021
Member
Author
FWIW; I recalled I had a patch for that in #42509, but it has other changes as well, perhaps I'll extract the |
thaJeztah
added a commit
to thaJeztah/buildkit
that referenced
this pull request
Aug 20, 2021
USING https://github.com/thaJeztah/docker/tree/TEMP_CLEANED_DOCKER branch, which includes moby/moby#42757 Signed-off-by: Sebastiaan van Stijn <[email protected]>
tianon
approved these changes
Aug 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was only used for two consts, which are unlikely to change, but the
"opts" package currently also imports libnetwork/ipamutils, which has
an
init()function that does some heavy lifting, and not needed forthis utility's purpose.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)