Remove LCOW (step 6)#42683
Conversation
thaJeztah
added
status/2-code-review
kind/experimental
impact/deprecation
area/lcow
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
remove_lcow_step6
branch
from
b5beee4 to
13cb04e
Compare
| // DefaultLinuxSpec create a default spec for running Linux containers | ||
| func DefaultLinuxSpec() specs.Spec { | ||
| s := specs.Spec{ | ||
| return specs.Spec{ |
There was a problem hiding this comment.
Changes in this file are easiest reviewed with "ignore whitespace"; https://github.com/moby/moby/pull/42683/files?w=1
|
|
||
| func (p *v2Puller) pullSchema1(ctx context.Context, ref reference.Reference, unverifiedManifest *schema1.SignedManifest, platform *specs.Platform) (id digest.Digest, manifestDigest digest.Digest, err error) { | ||
| if platform != nil { | ||
| // Early bath if the requested OS doesn't match that of the configuration. |
There was a problem hiding this comment.
Comment was already there. I can only assume John wrote that, as it looks to be an 🇬🇧 expression https://dictionary.cambridge.org/dictionary/english/an-early-bath
|
|
||
| # Detach any VHDs | ||
| gwmi msvm_mountedstorageimage -namespace root/virtualization/v2 -ErrorAction SilentlyContinue | foreach-object {$_.DetachVirtualHardDisk() } | ||
| gwmi msvm_mountedstorageimage -namespace root/virtualization/v2 -ErrorAction SilentlyContinue | foreach-Object {$_.DetachVirtualHardDisk() } |
There was a problem hiding this comment.
Hmm I think that was when I fixed the alias, but I see Foreach does not have a capital here either; must've overlooked that when extracting this from the other PR
| if (-not ("$env:DOCKER_STORAGE_OPTS" -eq "")) { | ||
| Write-Host -ForegroundColor Green "INFO: Running the daemon under test with storage-driver options ${env:DOCKER_STORAGE_OPTS}" | ||
| $env:DOCKER_STORAGE_OPTS.Split(",") | ForEach { | ||
| $env:DOCKER_STORAGE_OPTS.Split(",") | ForEach-Object { |
There was a problem hiding this comment.
Linter complaining that Foreach is an alias, and that should not be used as it could lead to unpredictable behavior
3 participants
Splitting off more bits from #42170