Dockerfile: update go-swagger to fix validation on Go1.16#42592
Merged
AkihiroSuda merged 1 commit intomoby:masterfrom Jul 3, 2021
Merged
Dockerfile: update go-swagger to fix validation on Go1.16#42592AkihiroSuda merged 1 commit intomoby:masterfrom
AkihiroSuda merged 1 commit intomoby:masterfrom
Conversation
Member
Author
|
Relates to #42583 |
Member
Author
|
LOL... erm, so, 🤷♂️ |
Member
Author
|
Ah! sigh.. long live suppressing all output, I guess diff --git a/hack/validate/swagger-gen b/hack/validate/swagger-gen
index 0d000ea39b..f2bea7285e 100755
--- a/hack/validate/swagger-gen
+++ b/hack/validate/swagger-gen
@@ -8,7 +8,7 @@ files=($(validate_diff --diff-filter=ACMR --name-only -- 'api/types/' 'api/swagg
unset IFS
if [ -n "${TEST_FORCE_VALIDATE:-}" ] || [ ${#files[@]} -gt 0 ]; then
- "${SCRIPTDIR}"/../generate-swagger-api.sh 2> /dev/null
+ "${SCRIPTDIR}"/../generate-swagger-api.sh
# Let see if the working directory is clean
diffs="$(git diff -- api/types/)"
if [ "$diffs" ]; then |
thaJeztah
force-pushed
the
update_swagger_fork
branch
from
57d5dd2 to
e9992b5
Compare
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
update_swagger_fork
branch
from
e9992b5 to
42d2048
Compare
Member
Author
^^ that's no longer true. Not editing the comment though, to prevent Jenkins form restarting the build (https://ci-next.docker.com/public/blue/organizations/jenkins/moby/detail/PR-42592/7/pipeline/333) |
tianon
reviewed
Jul 2, 2021
tianon
approved these changes
Jul 2, 2021
Member
tianon
left a comment
tianon
left a comment
There was a problem hiding this comment.
LGTM (relevant stage in Jenkins appears to be passing)
AkihiroSuda
approved these changes
Jul 3, 2021
This was referenced Jul 3, 2021
Merged
|
@thaJeztah this seems to be solved right? |
Member
Author
|
The issue only affected the Dockerfile we used in our CI, and this PR fixed it yes |
|
Alright as my first contribution to Moby do you mind if I go through open issues that might have been solved and point you to them so you can close them. I noticed a couple of issues that might have been solved but they are still open, this would give first timers a lot of headaches. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on kolyshkin/go-swagger#2
relates to #40353
temporarily using my fork to test this in CI