Merged
Conversation
Member
|
❤️❤️ thanks! will have a closer look tomorrow, but SGTM |
thaJeztah
reviewed
Jun 21, 2021
libnetwork/Makefile
Outdated
Comment on lines
-103
to
-106
Member
There was a problem hiding this comment.
Did we integrate this somewhere else?
Member
|
Looks like CI is failing; probably some changes needed for the move of docker-proxy to a different location; |
thaJeztah
reviewed
Jun 23, 2021
hack/make/dynbinary-proxy
Outdated
Member
There was a problem hiding this comment.
Ah! Guess this is the cause;
Suggested change
| GO_PACKAGE='github.com/docker/docker/cmd/dockeer-proxy' | |
| GO_PACKAGE='github.com/docker/docker/cmd/docker-proxy' |
Signed-off-by: Brian Goff <[email protected]>
This was used for testing purposes when libnetwork was in a separate repo. Now that it is integrated we no longer need it since dockerd and docker cli provide the same function. Signed-off-by: Brian Goff <[email protected]>
Since this command is part of the official distribution and even required for tests, let's move this up to the main cmd's. Signed-off-by: Brian Goff <[email protected]>
This is another one of those tools to mimic the docker network cli. It is not needed anymore, along with an old fork of the docker flag packages which was a fork of the go flag package. Signed-off-by: Brian Goff <[email protected]>
These were purposefully ignored before but this goes ahead and "fixes" most of them. Note that none of the things gosec flagged are problematic, just quieting the linter here. Signed-off-by: Brian Goff <[email protected]>
Not sure how this got added in there... Signed-off-by: Brian Goff <[email protected]>
It's no longer used Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
libnet_cleanup
branch
from
ad197d1 to
2050e08
Compare
Member
|
I rebased, fixed the typo (to see if that fixes the issue), and removed the |
thaJeztah
added
area/networking
Member
|
More flakes of #42459 in CI, rerunning. |
akerouanton
added a commit
to akerouanton/docker
that referenced
this pull request
Feb 9, 2023
- GetIfaceAddr is unused since moby/libnetwork#670 - ValidateAlias and ParseAlias are unused since moby#42539 Signed-off-by: Albin Kerouanton <[email protected]>
akerouanton
added a commit
to akerouanton/docker
that referenced
this pull request
Feb 16, 2023
- GetIfaceAddr is unused since moby/libnetwork@e51ead59 (moby/libnetwork#670). - ValidateAlias and ParseAlias are unused since moby/moby@0645eb84 (moby#42539). Signed-off-by: Albin Kerouanton <[email protected]>
akerouanton
added a commit
to akerouanton/docker
that referenced
this pull request
Feb 16, 2023
- GetIfaceAddr is unused since moby/libnetwork@e51ead59 (moby/libnetwork#670). - ValidateAlias and ParseAlias are unused since moby/moby@0645eb84 (moby#42539). Signed-off-by: Albin Kerouanton <[email protected]>
akerouanton
added a commit
to akerouanton/docker
that referenced
this pull request
Mar 2, 2023
- GetIfaceAddr is unused since moby/libnetwork@e51ead59 (moby/libnetwork#670). - ValidateAlias and ParseAlias are unused since moby/moby@0645eb84 (moby#42539). Signed-off-by: Albin Kerouanton <[email protected]>
akerouanton
added a commit
to akerouanton/docker
that referenced
this pull request
Mar 2, 2023
- GetIfaceAddr is unused since moby/libnetwork@e51ead59 (moby/libnetwork#670). - ValidateAlias and ParseAlias are unused since moby/moby@0645eb84 (moby#42539). Signed-off-by: Albin Kerouanton <[email protected]>
akerouanton
added a commit
to akerouanton/docker
that referenced
this pull request
Mar 6, 2023
- GetIfaceAddr is unused since moby/libnetwork@e51ead59 (moby/libnetwork#670). - ValidateAlias and ParseAlias are unused since moby/moby@0645eb84 (moby#42539). Signed-off-by: Albin Kerouanton <[email protected]>
akerouanton
added a commit
to akerouanton/docker
that referenced
this pull request
Mar 31, 2023
- GetIfaceAddr is unused since moby/libnetwork@e51ead59 (moby/libnetwork#670). - ValidateAlias and ParseAlias are unused since moby/moby@0645eb84 (moby#42539). Signed-off-by: Albin Kerouanton <[email protected]>
akerouanton
added a commit
to akerouanton/docker
that referenced
this pull request
Mar 31, 2023
- GetIfaceAddr is unused since moby/libnetwork@e51ead59 (moby/libnetwork#670). - ValidateAlias and ParseAlias are unused since moby/moby@0645eb84 (moby#42539). Signed-off-by: Albin Kerouanton <[email protected]>
akerouanton
added a commit
to akerouanton/docker
that referenced
this pull request
Apr 6, 2023
- GetIfaceAddr is unused since moby/libnetwork@e51ead59 (moby/libnetwork#670). - ValidateAlias and ParseAlias are unused since moby/moby@0645eb84 (moby#42539). Signed-off-by: Albin Kerouanton <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commits for details.
Related to #42471