vendor: moby/term, Azure/go-ansiterm for golang.org/x/sys/windows compatibility#42508
Merged
Conversation
thaJeztah
added
status/2-code-review
process/cherry-pick
kind/bugfix
Member
Author
|
Failure is unrelated |
Member
Author
|
I'll update once moby/term#29 is merged |
…patibility - winterm: GetStdFile(): Added compatibility with "golang.org/x/sys/windows" - winterm: fix GetStdFile() falltrough - update deprecation message to refer to the correct replacement - add go.mod - Fix int overflow - Convert int to string using rune() full diff: - moby/term@bea5bbe...3f7ff69 - Azure/go-ansiterm@d6e3b33...d185dfc Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
bump_term_ansiterm
branch
from
June 21, 2021 11:26
ef88b4a to
af1e745
Compare
Member
Author
Updated 👍 |
Member
Author
|
@cpuguy83 @AkihiroSuda PTAL |
AkihiroSuda
approved these changes
Jun 21, 2021
Member
Author
|
@cpuguy83 PTAL |
|
This was backported to 20.10.8 for the docker cli, but not for moby/dockerd, which prevents registering the service from a legacy cli. Can it go into the next 20.10.x release? e.g.: |
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to:
Changes:
full diff:
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)