libnetwork: replace BurntSushi/toml with pelletier/go-toml#42465
libnetwork: replace BurntSushi/toml with pelletier/go-toml#42465thaJeztah merged 1 commit intomoby:masterfrom
Conversation
|
let's wait until #42249 is merged, otherwise vendor check on master will fail (when it's merged, I'll revendor so that the dependency will be removed) |
|
#42249 is merged so @thaJeztah this is ready to be rebased |
The BurntSushi project is no longer maintained, and the container ecosystem is moving to use the pelletier/go-toml project instead. This patch moves libnetwork to use the pelletier/go-toml library, to reduce our dependency tree and use the same library in all places. Signed-off-by: Sebastiaan van Stijn <[email protected]>
|
Arf.. looks like BuildKit also still uses it, so looks like I need to open a PR there to replace it; A bit odd though that we're importing from a |
|
Anyway; rebased; 🤞 hopefully not hitting a flaky test this time |
|
Arm64 failing on the flaky libnetwork test; #42459 |
|
Windows now failing on the same test 😞. Kicking CI again |
|
Failure (again) on arm64: |
|
This is gonna be playing "whack-a-mole"; if other platforms pass, I'll merge, as we'd have had a green run for all jobs (in different combinations), and they should be unrelated anyway |
|
Everything else is green; bringing this one in |
replaces moby/libnetwork#2627
relates to #42246
Dependency will go away once #42249 is merged
The BurntSushi project is no longer maintained, and the container ecosystem is moving to use the pelletier/go-toml project instead.
This patch moves libnetwork to use the pelletier/go-toml library, to reduce our dependency tree and use the same library in all places.