vendor: github.com/moby/buildkit v0.8.3-3-g244e8cde#42424
Merged
Conversation
full diff: moby/buildkit@v0.8.2...v0.8.3 - vendor containerd (required for rootless overlayfs on kernel 5.11) - not included to avoid depending on a fork - Add retry on image push 5xx errors - contenthash: include basename in content checksum for wildcards - Fix missing mounts in execOp cache map - Add regression test for run cache not considering mounts - Add hack to preserve Dockerfile RUN cache compatibility after mount cache bugfix Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
area/builder
Member
Author
|
@tonistiigi @AkihiroSuda PTAL I didn't take the containerd vendoring changes to avoid having to depend on a fork; is there a way we can use (e.g.) a tagged version of containerd with the needed fixes? |
thaJeztah
commented
May 26, 2021
| // containerd: Forked from 0edc412565dcc6e3d6125ff9e4b009ad4b89c638 (20201117) with: | ||
| // - `Adjust overlay tests to expect "index=off"` (#4719, for ease of cherry-picking #5076) | ||
| // - `overlay: support "userxattr" option (kernel 5.11)` (#5076) | ||
| // - `docker: avoid concurrent map access panic` (#4855) |
Member
|
For v21.xx, can we rather vendor the master branch? |
Member
Author
|
I think it's ok to update after that; thought we'd take this one (possibly cherry-pick for 20.10) I need to look at updating runc etc (had some WIP pr's for that) for master |
Member
|
Yeah, we should pick v0.8.3 + moby/buildkit#2137 directly to 20.10 . |
full diff: moby/buildkit@v0.8.3...v0.8.3-3-g244e8cde - Transform relative mountpoints for exec mounts in the executor - Add test for handling relative mountpoints Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
changed the title
Member
Author
|
added moby/buildkit#2137 and opened #42448 for 20.10 |
AkihiroSuda
approved these changes
May 31, 2021
tonistiigi
approved these changes
Jun 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vendor: github.com/moby/buildkit v0.8.3-3-g244e8cde
full diff: moby/buildkit@v0.8.3...v0.8.3-3-g244e8cde
vendor: github.com/moby/buildkit v0.8.3
full diff: moby/buildkit@v0.8.2...v0.8.3
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)