Skip to content

pkg/signal: ignore SIGURG on all platforms#42415

Merged
AkihiroSuda merged 1 commit intomoby:masterfrom
thaJeztah:more_ignore
May 26, 2021
Merged

pkg/signal: ignore SIGURG on all platforms#42415
AkihiroSuda merged 1 commit intomoby:masterfrom
thaJeztah:more_ignore

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented May 25, 2021

follow-up to #42397
relates to docker/cli#3103

Other Unix platforms (e.g. Darwin) are also affected by the Go
runtime sending SIGURG.

This patch changes how we match the signal by just looking for the
"URG" name, which should handle any platform that has this signal
defined in the SignalMap.

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Other Unix platforms (e.g. Darwin) are also affected by the Go
runtime sending SIGURG.

This patch changes how we match the signal by just looking for the
"URG" name, which should handle any platform that has this signal
defined in the SignalMap.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah
Copy link
Member Author

@cpuguy83 @djs55 @AkihiroSuda ptal

@thaJeztah thaJeztah added this to the 21.xx milestone May 25, 2021
Copy link
Contributor

@djs55 djs55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, makes sense to me!

@thaJeztah thaJeztah mentioned this pull request May 25, 2021
20 tasks
Copy link
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member Author

@tonistiigi ptal 🤗

@AkihiroSuda AkihiroSuda merged commit c613447 into moby:master May 26, 2021
@thaJeztah thaJeztah deleted the more_ignore branch May 26, 2021 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants