contrib/check-config.sh: Remove awk dependency#42409
contrib/check-config.sh: Remove awk dependency#42409samuelkarp merged 1 commit intomoby:masterfrom joakimr-axis:joakimr-axis_noawk
Conversation
|
I see that the Recursively delete the current directory from the workspace part in https://ci-next.docker.com/public/blue/organizations/jenkins/moby/detail/PR-42409/2/pipeline fails. I don't think that step is related to the changes in this PR and should not be expected to fail? |
thaJeztah
added
area/contrib
kind/refactor
Yes, shouldn't be related; I restarted CI |
|
@tianon PTAL |
Strange, the same issue with Recursively delete the current directory from the workspace now with the new run too. |
The awk dependency is an issue when running check-config.sh on systems without awk. The use of awk can be replaced with sed, which improves portability. The PR code review discussion iterated via grep to this final sed version that is all Tianon Gravi's art. Co-authored-by: Tianon Gravi <[email protected]> Signed-off-by: Joakim Roubert <[email protected]>
|
|
4 participants
- What I did
Remove awk dependency in
contrib/check-config.sh- How I did it
Use grep and built-in functionality
- How to verify it
Run on host without awk
- Description for the changelog
Remove awk dependency in contrib/check-config.sh
- A picture of a cute animal (not mandatory but encouraged)