pkg/fileutils: TestMatches: remove cases no longer valid for go1.16#42390
Merged
cpuguy83 merged 1 commit intomoby:masterfrom May 20, 2021
Merged
pkg/fileutils: TestMatches: remove cases no longer valid for go1.16#42390cpuguy83 merged 1 commit intomoby:masterfrom
cpuguy83 merged 1 commit intomoby:masterfrom
Conversation
These tests were no longer valid on Go 1.16; related to https://tip.golang.org/doc/go1.16#path/filepath > The Match and Glob functions now return an error if the unmatched part of > the pattern has a syntax error. Previously, the functions returned early on > a failed match, and thus did not report any later syntax error in the pattern. Causing the test to fail: === RUN TestMatches fileutils_test.go:388: assertion failed: error is not nil: syntax error in pattern: pattern="a\\" text="a" --- FAIL: TestMatches (0.00s) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Member
Author
|
@tonistiigi @cpuguy83 ptal |
tonistiigi
approved these changes
May 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to #40353
fixes #41953
These tests were no longer valid on Go 1.16; related to https://tip.golang.org/doc/go1.16#path/filepath
Causing the test to fail: