Skip to content

[20.10 backport] Update runc binary to v1.0.0-rc94#42388

Merged
AkihiroSuda merged 3 commits into
moby:20.10from
thaJeztah:20.10_backport_update_runc
May 19, 2021
Merged

[20.10 backport] Update runc binary to v1.0.0-rc94#42388
AkihiroSuda merged 3 commits into
moby:20.10from
thaJeztah:20.10_backport_update_runc

Conversation

@thaJeztah

@thaJeztah thaJeztah commented May 18, 2021

Copy link
Copy Markdown
Member

backport of:

full diff opencontainers/runc@v1.0.0-rc93...v1.0.0-rc94

release notes (https://github.com/opencontainers/runc/releases/tag/v1.0.0-rc94):

Potentially breaking changes:

  • cgroupv1: kernel memory limits are now always ignored, as kmemcg has
    been effectively deprecated by the kernel. Users should make use of
    regular memory cgroup controls.
  • libcontainer/cgroups: cgroup managers' Set now accept
    configs.Resources rather than configs.Cgroups
  • libcontainer/cgroups/systemd: reconnect and retry in case dbus
    connection is closed (after dbus restart)
  • libcontainer/cgroups/systemd: don't set limits in Apply

Bugfixes:

  • seccomp: fix 32-bit compilation errors (regression in rc93)
  • cgroupv2: blkio weight value conversion fix
  • runc init: fix a hang caused by deadlock in seccomp/ebpf loading code (regression in rc93)
  • runc start: fix "chdir to cwd: permission denied" for some setups (regression in rc93)
  • s390: fix broken terminal (regression in rc93)

Improvements:

  • runc start/exec: better diagnostics when container limits are too low
  • runc start/exec: better cleanup after failed runc init
  • cgroupv1: improve freezing chances
  • cgroupv2: multiple GetStats improvements
  • cgroupv2: fallback to setting io.weight if io.bfq.weight is not available
  • capabilities: WARN, not ERROR, for unknown / unavailable capabilities

AkihiroSuda and others added 3 commits May 18, 2021 09:25
@AkihiroSuda @thaJeztah
Swarm config: use absolute paths for mount destination strings
afbb127 
Needed for runc >= 1.0.0-rc94.

See runc issue 2928.

Signed-off-by: Akihiro Suda <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit 9303376)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@tao12345666333 @thaJeztah
Update runc binary to v1.0.0-rc94
6174e3c 
Signed-off-by: Jintao Zhang <[email protected]>
(cherry picked from commit 8c019e8)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@AkihiroSuda @thaJeztah
integration: remove KernelMemory tests
4c801fd 
Starting with runc v1.0.0-rc94, runc no longer supports KernelMemory.

opencontainers/runc@52390d6

Signed-off-by: Akihiro Suda <[email protected]>
(cherry picked from commit 2f0d666)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah added this to the 20.10.7 milestone May 18, 2021
@thaJeztah
thaJeztah requested a review from tianon as a code owner May 18, 2021 07:27
@thaJeztah

thaJeztah commented May 18, 2021

Copy link
Copy Markdown
Member Author

failure on s390x are known flaky tests; #41561

[2021-05-18T07:41:48.912Z] === FAIL: s390x.integration.container TestNetworkNat (1.11s)
[2021-05-18T07:41:48.912Z]     nat_test.go:34: assertion failed: error is not nil: dial tcp 172.17.0.2:8080: connect: connection refused
[2021-05-18T07:41:48.912Z]
[2021-05-18T07:41:48.912Z] === FAIL: s390x.integration.container TestNetworkLocalhostTCPNat (0.99s)
[2021-05-18T07:41:48.912Z]     nat_test.go:56: assertion failed: hi yall (msg string) !=  (string)
[2021-05-18T07:41:48.912Z]
[2021-05-18T07:41:48.912Z] === FAIL: s390x.integration.container TestNetworkLoopbackNat (1.11s)
[2021-05-18T07:41:48.912Z]     nat_test.go:73: assertion failed: error is not nil: Error response from daemon: cannot join network of a non running container: 8c017d681194ccba0baf69676f481bcc828d2f959ba25231da404517ed82be58
[2021-05-18T07:41:48.912Z]
[2021-05-18T07:41:48.912Z] === FAIL: s390x.integration.container TestRenameAnonymousContainer (5.34s)
[2021-05-18T07:41:48.912Z]     rename_test.go:168: assertion failed: 0 (int) != 1 (inspect.State.ExitCode int): container 92f872a5ea309c221617bd5a6870e7757d8d4f93b1410698999c78d0d490a203 exited with the wrong exitcode:
[2021-05-18T07:41:48.912Z]
[2021-05-18T07:41:48.912Z] === FAIL: s390x.integration.container TestHostnameDnsResolution (1.98s)
[2021-05-18T07:41:48.912Z]     run_linux_test.go:99: assertion failed:
[2021-05-18T07:41:48.912Z]         --- ←
[2021-05-18T07:41:48.912Z]         +++ →
[2021-05-18T07:41:48.912Z]         @@ -1 +1,2 @@
[2021-05-18T07:41:48.912Z]         +ping: bad address 'foobar'
[2021-05-18T07:41:48.912Z]
[2021-05-18T07:41:48.912Z]
[2021-05-18T07:41:48.912Z]     run_linux_test.go:100: assertion failed: 0 (int) != 1 (res.ExitCode int)

@AkihiroSuda
AkihiroSuda merged commit 989c08c into moby:20.10 May 19, 2021
@thaJeztah
thaJeztah deleted the 20.10_backport_update_runc branch May 19, 2021 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tianon tianon tianon approved these changes
@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees

No one assigned

Labels

area/runtime Runtime impact/changelog status/2-code-review

Projects

None yet

Milestone

20.10.7

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah @tianon @AkihiroSuda @tao12345666333