Skip to content

Swarm config: use absolute paths for mount destination strings #42370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cpuguy83 merged 1 commit into from
May 12, 2021
Merged

Swarm config: use absolute paths for mount destination strings #42370

cpuguy83 merged 1 commit into from
May 12, 2021

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented May 11, 2021 •
edited
Loading

relates to #42369

taking from #42308, with my review suggestions from #42308 (comment) applied

Needed for runc >= 1.0.0-rc94.

See runc issue opencontainers/runc#2928 (introduced in opencontainers/runc#2917).

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

This was referenced May 11, 2021
Closed
Merged
@thaJeztah thaJeztah added this to the 21.xx milestone May 11, 2021
@thaJeztah thaJeztah requested a review from AkihiroSuda May 11, 2021 10:41
@thaJeztah thaJeztah force-pushed the fix_config_abspath branch from 6cca2d7 to eca6b02 Compare May 11, 2021 10:45
@AkihiroSuda @thaJeztah
Swarm config: use absolute paths for mount destination strings
9303376 
Needed for runc >= 1.0.0-rc94.

See runc issue 2928.

Signed-off-by: Akihiro Suda <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah force-pushed the fix_config_abspath branch from eca6b02 to 9303376 Compare May 11, 2021 10:46
@thaJeztah
Copy link
Member Author

thaJeztah commented May 11, 2021

LOL, interesting error when CI is started on Windows RS5 ( The recommended git tool is: git 🤔 😂)

[2021-05-11T10:47:53.972Z] The recommended git tool is: git
java.io.IOException: Remote call on JNLP4-connect connection from 138.91.242.246/138.91.242.246:49921 failed

@thaJeztah
Copy link
Member Author

thaJeztah commented May 11, 2021

@cpuguy83 ptal

cpuguy83
cpuguy83 approved these changes May 12, 2021
View reviewed changes
Copy link
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpuguy83 cpuguy83 merged commit 93477e3 into moby:master May 12, 2021
@thaJeztah thaJeztah deleted the fix_config_abspath branch May 12, 2021 18:50
@thaJeztah thaJeztah mentioned this pull request May 18, 2021
Merged
This was referenced May 31, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpuguy83 cpuguy83 cpuguy83 approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

+1 more reviewer

@tao12345666333 tao12345666333 tao12345666333 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/runtime Runtime area/swarm kind/bugfix PR's that fix bugs process/cherry-picked status/2-code-review

Projects

None yet

Milestone

23.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah @cpuguy83 @tao12345666333 @AkihiroSuda