Skip to content

Update runc binary to v1.0.0-rc94 #42369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cpuguy83 merged 2 commits into from
May 17, 2021
Merged

Update runc binary to v1.0.0-rc94 #42369

cpuguy83 merged 2 commits into from
May 17, 2021

Conversation

@tao12345666333
Copy link
Contributor

@tao12345666333 tao12345666333 commented May 11, 2021 •
edited by thaJeztah
Loading

full diff opencontainers/runc@v1.0.0-rc93...v1.0.0-rc94

release notes (https://github.com/opencontainers/runc/releases/tag/v1.0.0-rc94):

Potentially breaking changes:

  • cgroupv1: kernel memory limits are now always ignored, as kmemcg has
    been effectively deprecated by the kernel. Users should make use of
    regular memory cgroup controls.
  • libcontainer/cgroups: cgroup managers' Set now accept
    configs.Resources rather than configs.Cgroups
  • libcontainer/cgroups/systemd: reconnect and retry in case dbus
    connection is closed (after dbus restart)
  • libcontainer/cgroups/systemd: don't set limits in Apply

Bugfixes:

  • seccomp: fix 32-bit compilation errors (regression in rc93)
  • cgroupv2: blkio weight value conversion fix
  • runc init: fix a hang caused by deadlock in seccomp/ebpf loading code (regression in rc93)
  • runc start: fix "chdir to cwd: permission denied" for some setups (regression in rc93)
  • s390: fix broken terminal (regression in rc93)

Improvements:

  • runc start/exec: better diagnostics when container limits are too low
  • runc start/exec: better cleanup after failed runc init
  • cgroupv1: improve freezing chances
  • cgroupv2: multiple GetStats improvements
  • cgroupv2: fallback to setting io.weight if io.bfq.weight is not available
  • capabilities: WARN, not ERROR, for unknown / unavailable capabilities

@tao12345666333 tao12345666333 requested a review from tianon as a code owner May 11, 2021 02:04
AkihiroSuda
AkihiroSuda requested changes May 11, 2021
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see #42308 to fix up the mount path and KernelMemory

@tao12345666333
Copy link
Contributor Author

tao12345666333 commented May 11, 2021

@AkihiroSuda Should I submit it directly on this PR, or will you separate the commits in #42308

@AkihiroSuda
Copy link
Member

AkihiroSuda commented May 11, 2021

Should I submit it directly on this PR, or will you separate the commits in #42308

You may cherry-pick my commits from #42308 (if you would like).

@thaJeztah thaJeztah mentioned this pull request May 11, 2021
Merged
@thaJeztah
Copy link
Member

thaJeztah commented May 11, 2021

Should I submit it directly on this PR, or will you separate the commits in #42308

You may cherry-pick my commits from #42308 (if you would like).

I opened #42370 for the mount path fix, as they should be ok for older runc versions as well (but the kernel-memory test changes should probably be cherry-picked into this PR)

@AkihiroSuda AkihiroSuda mentioned this pull request May 11, 2021
Closed
@tao12345666333
Copy link
Contributor Author

tao12345666333 commented May 11, 2021

You may cherry-pick my commits from #42308 (if you would like).

Sure! Thanks for your work. Let me update this.

@AkihiroSuda @tao12345666333
integration: remove KernelMemory tests
2f0d666 
Starting with runc v1.0.0-rc94, runc no longer supports KernelMemory.

opencontainers/runc@52390d6

Signed-off-by: Akihiro Suda <[email protected]>
@tao12345666333
Copy link
Contributor Author

tao12345666333 commented May 11, 2021

I have cherry-picked @AkihiroSuda 's commits. (kernel-memory test changes)
May need to wait #42370 for the mount path fix.

thaJeztah
thaJeztah approved these changes May 12, 2021
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yes, this will go green / depends on #42370 to be merged

@thaJeztah thaJeztah added this to the 21.xx milestone May 12, 2021
tianon
tianon approved these changes May 13, 2021
View reviewed changes
Copy link
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YanzhaoLi
Copy link

YanzhaoLi commented May 13, 2021

Hi, will this be patched into docker version 19.03.x?

BTW, since kuberentes 1.20.x depends on docker 19.03 whose latest containerd version is 1.3.9 which doesn't include runc-1.0.0-rc94.
So can I just patch the containerd 1.4.5 into docker 19.03? Will that breaking docker or can I have test to verify the compatibility?

@thaJeztah thaJeztah mentioned this pull request May 17, 2021
Merged
@tao12345666333
Copy link
Contributor Author

tao12345666333 commented May 17, 2021

ping @thaJeztah can we merge this?

@cpuguy83 cpuguy83 merged commit a2b0c72 into moby:master May 17, 2021
@tao12345666333 tao12345666333 deleted the bump-runc-rc94 branch May 18, 2021 03:41
@thaJeztah thaJeztah mentioned this pull request May 18, 2021
Merged
@thaJeztah thaJeztah mentioned this pull request Mar 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tianon tianon tianon approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees

No one assigned

Labels

area/runtime Runtime impact/changelog process/cherry-picked status/4-merge

Projects

None yet

Milestone

23.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@tao12345666333 @AkihiroSuda @thaJeztah @YanzhaoLi @tianon @cpuguy83