hack/dind: fix cgroup v2 evacuation with docker run --init#42331
Merged
Conversation
AkihiroSuda
added
area/cgroup2
tianon
reviewed
Apr 27, 2021
Evacuate all the processes in `/sys/fs/cgroup/cgroup.procs`, not just PID 1. Before: ```console $ docker run --rm --privileged --init $(docker build -q .) cat /sys/fs/cgroup/cgroup.subtree_control sed: couldn't flush stdout: Device or resource busy ``` After: ```console $ docker run --rm --privileged --init $(docker build -q .) cat /sys/fs/cgroup/cgroup.subtree_control cpuset cpu io memory hugetlb pids rdma ``` Fix docker-library/docker issue 308 Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda
force-pushed
the
dind-fix-cgroup2-evac
branch
from
April 28, 2021 04:30
b521923 to
42b1175
Compare
tianon
approved these changes
Apr 28, 2021
tianon
left a comment
tianon
left a comment
Member
There was a problem hiding this comment.
LGTM! Thanks for looking into this and figuring out a fix 💪😎
Member
|
Failures are unrelated; this one is interesting though (on Windows RS5); hopefully just a hiccup |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Fix docker-library/docker#308
- How I did it
Evacuate all the processes in
/sys/fs/cgroup/cgroup.procs, not just PID 1.- How to verify it
Before:
After: