[20.10] Bump hcsshim for error details fix#42292
Merged
Merged
Conversation
Signed-off-by: Brian Goff <[email protected]>
Member
Author
|
Error is due to error string matching no longer working since the returned error no longer contains the container command, tracking this in #42270 |
Whether or not the command path is in the error message is a an implementation detail. For example, on Windows the only reason this ever matched was because it dumped the entire container config into the error message, but this had nothing to do with the actual error. Signed-off-by: Brian Goff <[email protected]> (cherry picked from commit 225e046) Signed-off-by: Brian Goff <[email protected]>
Member
|
@tonistiigi @tianon ptal |
AkihiroSuda
approved these changes
May 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pulls in fixes from the moby branch for hcsshim that 20.10 uses.
Not bumping up to the latest release because the diff is huge.