Skip to content

client: extract FromEnv parts to separate WithXX options#42224

Merged
AkihiroSuda merged 1 commit into
moby:masterfrom
thaJeztah:more_client_opts
Feb 11, 2022
Merged

client: extract FromEnv parts to separate WithXX options#42224
AkihiroSuda merged 1 commit into
moby:masterfrom
thaJeztah:more_client_opts

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Mar 30, 2021 •
edited
Loading

relates to the discussion on #42222

Implements three options;

  • WithTLSClientConfigFromEnv()
  • WithHostFromEnv()
  • WithVersionFromEnv()

- Description for the changelog

Implement new options in the client package: 

- WithTLSClientConfigFromEnv()
- WithHostFromEnv()
- WithVersionFromEnv()

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah thaJeztah added area/api API status/2-code-review kind/refactor PR's that refactor, or clean-up code labels Mar 30, 2021
@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Apr 2, 2021 •
edited
Loading

Looks like this test has become flaky; (tracked through #42357)

--- FAIL: TestDaemonHostGatewayIP (4.55s)
    daemon_linux_test.go:161: [d89024ace079c] failed to start daemon with arguments [--data-root /go/src/github.com/docker/docker/bundles/test-integration/TestDaemonHostGatewayIP/d89024ace079c/root --exec-root /tmp/dxr/d89024ace079c --pidfile /go/src/github.com/docker/docker/bundles/test-integration/TestDaemonHostGatewayIP/d89024ace079c/docker.pid --userland-proxy=true --containerd-namespace d89024ace079c --containerd-plugins-namespace d89024ace079cp --containerd /var/run/docker/containerd/containerd.sock --host unix:///tmp/docker-integration/d89024ace079c.sock --debug --storage-driver overlay2 --host-gateway-ip=6.7.8.9] : [d89024ace079c] daemon exited during startup: exit status 1

@thaJeztah thaJeztah force-pushed the more_client_opts branch 2 times, most recently from 75550a2 to aa1f6ab Compare May 6, 2021 14:42
@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Jun 21, 2021

@AkihiroSuda @samuelkarp ptal 🤗

@thaJeztah thaJeztah mentioned this pull request Dec 22, 2021
Closed
@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Jan 20, 2022

@tianon @AkihiroSuda ptal

@thaJeztah
client: extract FromEnv parts to separate WithXX options
eae20b1 
Implements three options;

- WithTLSClientConfigFromEnv()
- WithHostFromEnv()
- WithVersionFromEnv()

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@AkihiroSuda AkihiroSuda merged commit 3b02526 into moby:master Feb 11, 2022
@thaJeztah thaJeztah deleted the more_client_opts branch February 11, 2022 07:32
@thaJeztah thaJeztah added this to the 21.xx milestone Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tianon tianon tianon approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees

No one assigned

Labels

area/api API impact/changelog kind/refactor PR's that refactor, or clean-up code status/2-code-review

Projects

None yet

Milestone

23.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@thaJeztah @tianon @AkihiroSuda