Draft
Conversation
thaJeztah
added
status/2-code-review
impact/deprecation
area/lcow
thaJeztah
force-pushed
the
remove_lcow
branch
3 times, most recently
from
6aef7fc to
39ea4ba
Compare
thaJeztah
force-pushed
the
remove_lcow
branch
3 times, most recently
from
5cf1d4e to
44a7424
Compare
Member
Author
|
hmm.. flaky test? |
Merged
Merged
This was referenced Jun 10, 2021
thaJeztah
force-pushed
the
remove_lcow
branch
3 times, most recently
from
53b460c to
5b2fad2
Compare
thaJeztah
force-pushed
the
remove_lcow
branch
4 times, most recently
from
41ba270 to
404655e
Compare
Merged
This was referenced Jul 27, 2021
thaJeztah
force-pushed
the
remove_lcow
branch
2 times, most recently
from
af2e6fa to
ddeb49e
Compare
Member
Author
|
Two failures that look related, but will have to look if the test may be wrong, or if it's an existing issue that wasn't hit before (possibly if base-image was "from scratch", it would be testing for Linux?) |
thaJeztah
force-pushed
the
remove_lcow
branch
from
9c6a177 to
f8ebfe0
Compare
thaJeztah
force-pushed
the
remove_lcow
branch
from
f8ebfe0 to
ae740a5
Compare
thaJeztah
commented
Aug 31, 2022
| return []string{}, runConfig.ArgsEscaped | ||
| } | ||
|
|
||
| if os == "windows" { // ie WCOW |
Member
Author
There was a problem hiding this comment.
Maybe this is the cause of the failure; could this be a "from scratch" case?
thaJeztah
force-pushed
the
remove_lcow
branch
from
ae740a5 to
6cb2bf7
Compare
thaJeztah
force-pushed
the
remove_lcow
branch
from
6cb2bf7 to
b8d6026
Compare
thaJeztah
force-pushed
the
remove_lcow
branch
from
b8d6026 to
677d0a2
Compare
Signed-off-by: Sebastiaan van Stijn <[email protected]>
These tests were previously using the linux format, probably because the image is empty Signed-off-by: Sebastiaan van Stijn <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LCOW implementation in dockerd has been deprecated in favor of re-implementation in containerd (in progress). Microsoft started removing the LCOW V1 code from the build dependencies we use in Microsoft/opengcs in microsoft/opengcs@e972b27 (microsoft/opengcs#390), soon to be part of Microsoft/hcshhim (microsoft/hcsshim#973).
The (pre microsoft/opengcs@e972b27) version of opengcs we need for LCOW v1 is no longer compatible with current versions of runc/libcontainer (see microsoft/opengcs#396), which means that we wouldn't be able to update our runtime (containerd, runc) dependencies without breaking LCOW v1.
With the above; and given that LCOW has been deprecated (but so far, not actively removed), we should make a start to remove this code.
WARNING:
I should be clear that this is not ready to be merged, and a really WIP branch. This branch is just "blindly" ripping out all LCOW-related code/code-paths. See it as a "what if we removed all bits.." to make visible where the LCOW code-paths live, and so that we can discuss what parts should be removed, and possibly, what parts should be kept (For example, if we want to support LCOW based on containerd, possibly some of this code is still useful)