Add an option to skip create log stream for awslogs driver#42132
Merged
Conversation
Added an option `awslogs-create-stream` to allow skipping log stream creation for awslogs log driver. The default value is still true to keep the behavior be consistent with before. Signed-off-by: Xia Wu <[email protected]>
Member
|
/cc @samuelkarp @estesp |
kzys
approved these changes
Apr 22, 2021
Member
|
Close/reopen to see if I can trigger Jenkins again (old run is now a 404). |
Member
|
Looks like we also need a documentation change to document the new option. @xia-wu are you interested in opening a draft PR for that? |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an option
awslogs-create-streamto allow skipping log stream creation forawslogslog driver. The default value is stilltrueto keep the behavior be consistent with before.Signed-off-by: Xia Wu [email protected]
- What I did
Added a new option
awslogs-create-streamtoawslogslog driver to allow skipping log stream creation in AWS CloudWatch Logs. It's very similar toawslogs-create-groupbut used for log stream creation.- How I did it
Added a new option in
awslogslog config map.- How to verify it
awslogs-create-stream=falsewith an existed log stream name in AWS CloudWatch Logs, the log stream creation was skipped and container started to run successfully.awslogs-create-streamand the log stream created in CloudWatch Logs successfully.- Description for the changelog
Added a new option to
awslogslog driver to allow skipping log stream creation in AWS CloudWatch Logs.- A picture of a cute animal (not mandatory but encouraged)
