Skip to content

dockerd-rootless-setuptool.sh: create CLI context "rootless"#42084

Merged
thaJeztah merged 1 commit intomoby:masterfrom
AkihiroSuda:rootless-add-context
Mar 1, 2021
Merged

dockerd-rootless-setuptool.sh: create CLI context "rootless"#42084
thaJeztah merged 1 commit intomoby:masterfrom
AkihiroSuda:rootless-add-context

Conversation

@AkihiroSuda
Copy link
Copy Markdown
Member

- What I did
dockerd-rootless-setuptool.sh: create CLI context "rootless"

- How to verify it

$ dockerd-rootless-setuptool.sh install
...
[INFO] Creating CLI context "rootless"
Successfully created context "rootless"

[INFO] Make sure the following environment variables are set (or add them to ~/.bashrc):

export PATH=/usr/local/bin:$PATH
export DOCKER_HOST=unix:///run/user/1001/docker.sock
$ docker context ls
NAME        DESCRIPTION                               DOCKER ENDPOINT                     KUBERNETES ENDPOINT   ORCHESTRATOR
default *   Current DOCKER_HOST based configuration   unix:///var/run/docker.sock                               swarm
rootless    Rootless mode                             unix:///run/user/1001/docker.sock 

- Description for the changelog

dockerd-rootless-setuptool.sh: create CLI context "rootless"

- A picture of a cute animal (not mandatory but encouraged)

🐧

@AkihiroSuda AkihiroSuda added area/rootless Rootless Mode kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. impact/changelog labels Feb 26, 2021
@AkihiroSuda AkihiroSuda added this to the 21.xx milestone Feb 26, 2021
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@tianon ptal 🤗

Copy link
Copy Markdown
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine 👍

At some point we should probably add local to all these function variables (since their names are really generic and thus likely to collide), but this is consistent with the rest of the file.

@thaJeztah thaJeztah merged commit 40d9e2a into moby:master Mar 1, 2021
@AkihiroSuda
Copy link
Copy Markdown
Member Author

add local to all these function variables

This requires bash, right?

@tianon
Copy link
Copy Markdown
Member

tianon commented Mar 3, 2021

Doh, right -- forgot this was POSIX, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/rootless Rootless Mode impact/changelog kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. process/cherry-picked

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants