dockerd-rootless-setuptool.sh: create CLI context "rootless"#42084
Merged
thaJeztah merged 1 commit intomoby:masterfrom Mar 1, 2021
Merged
dockerd-rootless-setuptool.sh: create CLI context "rootless"#42084thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
Signed-off-by: Akihiro Suda <[email protected]>
thaJeztah
approved these changes
Mar 1, 2021
tianon
approved these changes
Mar 1, 2021
Member
tianon
left a comment
There was a problem hiding this comment.
Seems fine 👍
At some point we should probably add local to all these function variables (since their names are really generic and thus likely to collide), but this is consistent with the rest of the file.
Member
Author
This requires bash, right? |
Member
|
Doh, right -- forgot this was POSIX, sorry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
dockerd-rootless-setuptool.sh: create CLI context "rootless"
- How to verify it
- Description for the changelog
dockerd-rootless-setuptool.sh: create CLI context "rootless"
- A picture of a cute animal (not mandatory but encouraged)
🐧