Include VPNkit binary for arm64#42067
Conversation
4c0b32c to
155e597
Compare
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
Thanks! LGTM after the commit is changed to the tagged version (other nit is obviously not a blocker, so leaving that up to you)
Signed-off-by: Akihiro Suda <[email protected]>
155e597 to
088e6ee
Compare
|
@cpuguy83 ptal |
|
|
||
| FROM scratch AS vpnkit | ||
| COPY --from=vpnkit-amd64 /vpnkit /build/vpnkit.x86_64 | ||
| COPY --from=vpnkit-arm64 /vpnkit /build/vpnkit.aarch64 |
There was a problem hiding this comment.
Why are we putting multiple binaries into a stage, including binary for wrong arch? Just the one for the target platform should suffice.
There was a problem hiding this comment.
Ideally we could write this like COPY --from=vpnkit-${TARGETPLATFORM} /vpnkit /build/vpnkit, but we can't, because djs55/vpnkit:0.5.0 only contains amd64 and arm64 manifests.
tonistiigi
left a comment
tonistiigi
left a comment
There was a problem hiding this comment.
LGTM, but we should find some better solution for this as combining unwanted binaries for multiple platforms together does not scale. Either with some builder changes or changes to the vpnkit image cc @djs55
4 participants
Previously, VPNkit binary was installed only for amd64.