Skip to content

Check the length of the correct variable #42039#42044

Merged
thaJeztah merged 1 commit into
moby:masterfrom
nathanlcarlson:labels_regex_length_check
Feb 18, 2021
Merged

Check the length of the correct variable #42039#42044
thaJeztah merged 1 commit into
moby:masterfrom
nathanlcarlson:labels_regex_length_check

Conversation

@nathanlcarlson

Copy link
Copy Markdown

- What I did

- How I did it

- How to verify it

- Description for the changelog

Closes #42039

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah

Copy link
Copy Markdown
Member

Thanks! Looks like your commit message is missing a signed-off-by line; https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work

If you have your name and e-mail configured in your git configuration (see https://github.com/moby/moby/blob/master/docs/contributing/set-up-git.md#task-2-set-your-signature-and-an-upstream-remote)

You can amend your commit, and force-push to update the PR; assuming the remote pointing to your fork is named origin;

git commit -s --amend --no-edit
git push -f origin

Let me know if you need help 👍

@thaJeztah thaJeztah added area/logging dco/no Automatically set by a bot when one of the commits lacks proper signature kind/bugfix PR's that fix bugs process/cherry-pick status/2-code-review labels Feb 17, 2021
@thaJeztah thaJeztah added this to the 21.xx milestone Feb 17, 2021
@nathanlcarlson

Copy link
Copy Markdown
Author

Got it signed.

@cpuguy83 cpuguy83 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thanks!!

@thaJeztah

Copy link
Copy Markdown
Member

CI failure is unrelated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/logging dco/no Automatically set by a bot when one of the commits lacks proper signature kind/bugfix PR's that fix bugs process/cherry-picked status/2-code-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ExtraAttributes checking the wrong length for labels-regex

4 participants