[20.10 backport]: avoid creating parent dirs for XGlobalHeader, and fix permissions#42017
Merged
Merged
Conversation
thaJeztah
added
area/builder
thaJeztah
force-pushed
the
20.10_backport_build_fixes
branch
2 times, most recently
from
February 17, 2021 15:26
7d42a9d to
c7ac87f
Compare
Signed-off-by: Tonis Tiigi <[email protected]> (cherry picked from commit ba7906a) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Commit edb62a3 fixed a bug in MkdirAllAndChown() that caused the specified permissions to not be applied correctly. As a result of that bug, the configured umask would be applied. When extracting archives, Unpack() used 0777 permissions when creating missing parent directories for files that were extracted. Before edb62a3, this resulted in actual permissions of those directories to be 0755 on most configurations (using a default 022 umask). Creating these directories should not depend on the host's umask configuration. This patch changes the permissions to 0755 to match the previous behavior, and to reflect the original intent of using 0755 as default. Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit 25ada76) Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
20.10_backport_build_fixes
branch
from
February 17, 2021 20:13
c7ac87f to
5d442b1
Compare
Member
Author
|
rebased to trigger CI with test-fixes that were merged |
Member
Author
|
Not sure why this is failing on ppc64le; kicking again, but could be something related to that platform? edit: so... why is it loading |
tiborvass
approved these changes
Feb 18, 2021
tonistiigi
approved these changes
Feb 18, 2021
chia7712
pushed a commit
to apache/kafka
that referenced
this pull request
Jun 19, 2025
#19994) Adds a new section **"Installation Preparation"** to the Kafka Docker examples README. It documents a known issue with Docker versions prior to 20.10.4, where directory permissions (such as `/opt/kafka/config`) are not properly set, causing startup failures for non-root users (e.g., `appuser`). This issue was fixed in Docker [20.10.4 release](https://docs.docker.com/engine/release-notes/20.10/#20104), specifically in Use 0755 permissions when creating missing directories [moby/moby#42017](moby/moby#42017). Reviewers: Jhen-Yung Hsu <[email protected]>, Lan Ding <[email protected]>, Chia-Ping Tsai <[email protected]> --------- Co-authored-by: Jhen-Yung Hsu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #41978
backport of: