Fix for lack of synchronization in daemon/update.go#41999
Merged
Conversation
diakovliev
changed the title
diakovliev
marked this pull request as ready for review
February 8, 2021 14:18
thaJeztah
reviewed
Feb 8, 2021
thaJeztah
added
area/daemon
diakovliev
force-pushed
the
fix_update_sync
branch
from
February 9, 2021 07:32
3d9ed9f to
d1c7727
Compare
Signed-off-by: dmytro.iakovliev <[email protected]>
diakovliev
force-pushed
the
fix_update_sync
branch
from
February 9, 2021 07:34
d1c7727 to
58825ff
Compare
iurii-ovcharenko
approved these changes
Apr 7, 2021
|
We experiencing this issue in our organization several times a day. |
thaJeztah
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #41988
Signed-off-by: dmytro.iakovliev [email protected]
- What I did
Reordered operations to fix race.
- How I did it
The container state checking has been placed between container.Lock() and container.Unlock(). Added container state checking into the defer handler.
- How to verify it
See script to reproduce failing conditions in #41988.
- Description for the changelog
Fix for lack of syncronization in daemon/update.go.