dockerd-rootless.sh: add typo guard#41960
Merged
Merged
Conversation
AkihiroSuda
added
kind/enhancement
Member
|
Should we combine the scripts, so that there's a single "entry-point" (script) both for installing and running ? |
Member
Author
I feel it will increase complexity and decrease maintainability. Also, it should be noted that dockerd can potentially have subcommands (as in containerd) and they may conflict with the subcommands of -setuptool.sh . |
`dockerd-rootless.sh install` is a common typo of `dockerd-rootless-setuptool.sh install`. Now `dockerd-rootless.sh install` shows human-readable error. Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda
force-pushed
the
rootless-typo-guard
branch
from
February 24, 2021 04:55
7c1cbbe to
8dc6c10
Compare
Member
|
@tianon ptal 🤗 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
dockerd-rootless.sh installis a common typo ofdockerd-rootless-setuptool.sh install.Now
dockerd-rootless.sh installshows human-readable error.- How I did it
Added a human-readable error
- How to verify it
- A picture of a cute animal (not mandatory but encouraged)
🐧