Skip to content

[20.10 backport] docker info: silence unhandleable warnings #41958

Merged
cpuguy83 merged 2 commits into
moby:20.10from
AkihiroSuda:cherrypick-41894-2010
Feb 2, 2021
Merged

[20.10 backport] docker info: silence unhandleable warnings #41958
cpuguy83 merged 2 commits into
moby:20.10from
AkihiroSuda:cherrypick-41894-2010

Conversation

@AkihiroSuda

Copy link
Copy Markdown
Member

Cherry-pick #41894

The following warnings in `docker info` are now discarded,
because there is no action user can actually take.

On cgroup v1:
- "WARNING: No blkio weight support"
- "WARNING: No blkio weight_device support"

On cgroup v2:
- "WARNING: No kernel memory TCP limit support"
- "WARNING: No oom kill disable support"

`docker run` still prints warnings when the missing feature is being attempted to use.

Signed-off-by: Akihiro Suda <[email protected]>
(cherry picked from commit 8086443)
Signed-off-by: Akihiro Suda <[email protected]>
Signed-off-by: Akihiro Suda <[email protected]>
(cherry picked from commit 00225e2)
Signed-off-by: Akihiro Suda <[email protected]>

@thaJeztah thaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpuguy83

cpuguy83 commented Feb 2, 2021

Copy link
Copy Markdown
Member

Looks like we need to backport another test fix: Build / rootless / Integration tests / TestRestartDaemonWithRestartingContainer – amd64.integration.container

@cpuguy83 cpuguy83 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpuguy83
cpuguy83 merged commit 49df387 into moby:20.10 Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants