Skip to content

Use golang.org/x/sys/execabs#41927

Merged
tiborvass merged 1 commit into
moby:masterfrom
tiborvass:execabs
Jan 26, 2021
Merged

Use golang.org/x/sys/execabs#41927
tiborvass merged 1 commit into
moby:masterfrom
tiborvass:execabs

Conversation

@tiborvass

@tiborvass tiborvass commented Jan 25, 2021

Copy link
Copy Markdown
Contributor

Signed-off-by: Tibor Vass [email protected]

@tiborvass
tiborvass requested a review from tonistiigi as a code owner January 25, 2021 18:50
thaJeztah
thaJeztah approved these changes Jan 25, 2021
View reviewed changes

@thaJeztah thaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tibor Vass
Use golang.org/x/sys/execabs
7ca0cb7 
Signed-off-by: Tibor Vass <[email protected]>
@tiborvass tiborvass mentioned this pull request Jan 25, 2021
Merged
@thaJeztah

thaJeztah commented Jan 26, 2021

Copy link
Copy Markdown
Member

Weird why this one is still failing; seems as if it's trying an empty name as image. It's also loading all frozen images, not just the one we're loading;

moby/integration/build/build_userns_linux_test.go

Line 44 in 41e5d45

err = load.FrozenImagesLinux(clientUserRemap, "buildpack-deps:buster") 

=== RUN   TestBuildUserNamespaceValidateCapabilitiesAreV2
Loaded image: buildpack-deps:buster
Loaded image: busybox:latest
Loaded image: busybox:glibc
Loaded image: debian:bullseye
Loaded image: hello-world:latest
Loaded image: arm32v7/hello-world:latest
--- FAIL: TestBuildUserNamespaceValidateCapabilitiesAreV2 (16.88s)
    build_userns_linux_test.go:82: assertion failed: error is not nil: Error response from daemon: reference does not exist: failed to download capabilities image

@thaJeztah thaJeztah mentioned this pull request Jan 26, 2021
Merged
@tiborvass

tiborvass commented Jan 26, 2021

Copy link
Copy Markdown
Contributor Author

The relevant CIs have passed so I'm merging.

@tiborvass
tiborvass merged commit d5209b2 into moby:master Jan 26, 2021
@thaJeztah thaJeztah added this to the 20.10.3 milestone Jan 27, 2021
@thaJeztah thaJeztah mentioned this pull request Jan 27, 2021
Closed
@thaJeztah thaJeztah modified the milestones: 20.10.3, 21.xx Feb 2, 2021
@thaJeztah thaJeztah mentioned this pull request Nov 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tonistiigi tonistiigi tonistiigi approved these changes
@thaJeztah thaJeztah thaJeztah approved these changes

Assignees

No one assigned

Labels

process/cherry-picked status/2-code-review

Projects

None yet

Milestone

23.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@tiborvass @thaJeztah @tonistiigi