docker info: silence unhandleable warnings#41894
Merged
Merged
Conversation
The following warnings in `docker info` are now discarded, because there is no action user can actually take. On cgroup v1: - "WARNING: No blkio weight support" - "WARNING: No blkio weight_device support" On cgroup v2: - "WARNING: No kernel memory TCP limit support" - "WARNING: No oom kill disable support" `docker run` still prints warnings when the missing feature is being attempted to use. Signed-off-by: Akihiro Suda <[email protected]>
thaJeztah
approved these changes
Jan 19, 2021
| // blkio weight is not available on cgroup v1 since kernel 5.0. | ||
| // Warning is not printed on cgroup v1, because there is no action user can take. | ||
| // On cgroup v2, blkio weight is implemented using io.weight | ||
| v.Warnings = append(v.Warnings, "WARNING: No blkio weight support") |
Member
There was a problem hiding this comment.
Do we need to update the warnings to match the new cgroup? (ok for a follow-up)
Signed-off-by: Akihiro Suda <[email protected]>
This was referenced Dec 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #41790
- What I did
The following warnings in
docker infoare now discarded, because there is no action user can actually take.On cgroup v1:
On cgroup v2:
docker runstill prints warnings when the missing feature is being attempted to use.- How I did it
See the code
- How to verify it
Run
docker info- Description for the changelog
docker info: silence unhandleable warnings
- A picture of a cute animal (not mandatory but encouraged)
🐧