pkg/archive: allow mknodding FIFO inside userns#41892
Merged
Merged
Conversation
AkihiroSuda
added
process/cherry-pick
area/rootless
tonistiigi
reviewed
Jan 19, 2021
Member
|
@AkihiroSuda can you update to check for |
Fix moby#41803 Also attempt to mknod devices. Mknodding devices are likely to fail, but still worth trying when running with a seccomp user notification. Signed-off-by: Akihiro Suda <[email protected]>
Member
Author
|
updated |
AkihiroSuda
force-pushed
the
fix-41803
branch
from
January 26, 2021 08:43
b49a244 to
d5d5ccc
Compare
thaJeztah
approved these changes
Jan 26, 2021
thaJeztah
left a comment
thaJeztah
left a comment
Member
There was a problem hiding this comment.
LGTM
@tonistiigi @cyphar PTAL
tonistiigi
approved these changes
Jan 28, 2021
Member
Author
|
This will be in v20.10.4 (#41957) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Fix #41803
Also attempt to mknod devices.
Mknodding devices are likely to fail, but still worth trying when running with a seccomp user notification.
- How I did it
By allowing mknodding FIFO inside userns.
- How to verify it
docker pull docker.io/gitlab/gitlab-ee:13.6.3-ee.0with rootless- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
🐧